Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpcbf hanging issue by closing stdin #1059

Merged
merged 1 commit into from
Jul 11, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Add [yapf](http://github.com/google/yapf) beautifier for Python.
- Closes [#776] (https://github.com/Glavin001/atom-beautify/issues/776) Add support for `collapse-preserve-inline` brace_style for javascript.
- Closes [#786](https://github.com/Glavin001/atom-beautify/issues/786) YAPF configuration files are ignored.
- Fix phpcbf hanging issue by closing stdin. See [#893](https://github.com/Glavin001/atom-beautify/issues/893)

# v0.29.0
- Closes [#447](https://github.com/Glavin001/atom-beautify/issues/447). Improved Handlebars language support
Expand Down
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@
{
"name": "Joost van Doorn",
"url": "https://github.com/JoostvDoorn"
},
{
"name": "Arman Yessenamanov",
"url": "https://github.com/yesenarman"
}
],
"engines": {
Expand Down
4 changes: 4 additions & 0 deletions src/beautifiers/phpcbf.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ module.exports = class PHPCBF extends Beautifier
help: {
link: "http://php.net/manual/en/install.php"
}
onStdin: (stdin) ->
stdin.end()
})
.then(=>
@readFile(tempFile)
Expand All @@ -79,6 +81,8 @@ module.exports = class PHPCBF extends Beautifier
help: {
link: "https://github.com/squizlabs/PHP_CodeSniffer"
}
onStdin: (stdin) ->
stdin.end()
})
.then(=>
@readFile(tempFile)
Expand Down