Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current implementation of DeviceRedirectionMITM can lead to request collision, leading to unpredictable behavior #222

Closed
Res260 opened this issue Apr 22, 2020 · 0 comments · Fixed by #244
Labels
bug Something isn't working

Comments

@Res260
Copy link
Collaborator

Res260 commented Apr 22, 2020

The current implementation of the DeviceRedirectionMITM only stores the requestID when a packet is received. This requestID is stored by PyRDP to look for specific types of anwsers.

However, the requestID is not unique and can be used by other devices, which PyRDP doesnt take into account. PyRDP should store a pair of deviceID, requestID instead of simply requestID.

I am unsure of the current impact of this. It probably can raise KeyErrors leading to the packet not being forwarded.

@Res260 Res260 added the bug Something isn't working label Apr 22, 2020
alxbl added a commit that referenced this issue Sep 14, 2020
fix(#222): Added device ID to I/O Requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant