Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#222): Added device ID to I/O Requests. #244

Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix(#222): Added device ID to I/O Requests. #244

merged 1 commit into from
Sep 14, 2020

Conversation

alxbl
Copy link
Collaborator

@alxbl alxbl commented Aug 21, 2020

Fixes #222

According to the spec FileID should be globally unique across devices so I didn't modify the file proxy map.

FileId (4 bytes):  A 32-bit unsigned integer that specifies a unique ID for the created file object. The ID MUST be reused after sending a Device Close Response (section 2.2.1.5.2).

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpefs/99e5fca5-b37a-41e4-bc69-8d7da7860f76

@alxbl
Copy link
Collaborator Author

alxbl commented Aug 21, 2020

Additionally: This doesn't resolve the 108 byte transfer issue, so it invalidates that theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant