Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix world-grab movement #608

Merged
merged 1 commit into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions VERSIONS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# 4.3.1
- Fix saving project when using plugin-tools to set physics layers or enable OpenXR
- Fix updating the editor-preview hand-pose
- Fix jumping on slopes
- Fix material warnings by converting binary .material files to .tres files
- Fix staging to use threaded loading while starting the fade
- Fix broken world-grab script

# 4.3.0
- Upgraded project to Godot 4.1 as the new minimum version.
- Added reporting of stage load errors.
Expand Down
2 changes: 1 addition & 1 deletion addons/godot-xr-tools/objects/world_grab_area.gd
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func request_highlight(_from, _on) -> void:
pass

# Called by XRToolsFunctionPickup when this is picked up by a controller
func pick_up(by: Node3D, _with_controller: XRController3D) -> void:
func pick_up(by: Node3D) -> void:
# Get the ID to save the grab handle under
var id = by.get_instance_id()

Expand Down
2 changes: 2 additions & 0 deletions addons/godot-xr-tools/objects/world_grab_area.tscn
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
[ext_resource type="Script" path="res://addons/godot-xr-tools/objects/world_grab_area.gd" id="1_uxhq5"]

[node name="WorldGrabArea" type="Area3D"]
collision_layer = 262144
collision_mask = 524288
script = ExtResource("1_uxhq5")
2 changes: 0 additions & 2 deletions scenes/world_grab_demo/world_grab_demo.tscn
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@ body_forward_mix = 0.0

[node name="WorldGrabAreaZeroG" parent="." index="2" instance=ExtResource("8_ochso")]
transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 5, 0)
collision_layer = 262144
collision_mask = 524288
gravity_space_override = 3
gravity = 0.0
linear_damp = 1.0
Expand Down
Loading