Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and test targets #221

Merged
merged 8 commits into from
Dec 3, 2020

Conversation

westy92
Copy link
Contributor

@westy92 westy92 commented Dec 1, 2020

  • Update TypeScript and other dependencies.
  • Update test targets. Current LTS and stable are 14.x and 15.x (https://nodejs.org/en/about/releases/).
  • Cleanup code; update imports to improve type hints and remove deprecations.

@Niek
Copy link
Contributor

Niek commented Dec 1, 2020

@patrickhulce any chance to merge this?

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @westy92 all of your stated goals are great 👍

just don't think we want to introduce breaking changes parts of this right now. maybe file an issue for the collection of breaking changes we'll want to batch for the next major? :)

.travis.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@westy92
Copy link
Contributor Author

westy92 commented Dec 1, 2020

I reverted the changes that require Node.js 10+. I'm happy to open another PR once this lands that drops Node.js 8.x support that can sit around until the project is ready for it.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @westy92 !

src/chrome-launcher.ts Outdated Show resolved Hide resolved
@westy92
Copy link
Contributor Author

westy92 commented Dec 3, 2020

You're welcome! I addressed all the comments and it looks like all the tests passed. 🎉 Is there anything else I need to do to get this merged in?

@patrickhulce patrickhulce merged commit beb4136 into GoogleChrome:master Dec 3, 2020
@patrickhulce
Copy link
Collaborator

nope I was just waiting on the tests and then forgot about it :) thanks @westy92 !

@westy92 westy92 deleted the update-deps branch December 3, 2020 23:24
@westy92
Copy link
Contributor Author

westy92 commented Dec 15, 2020

I'm happy to open another PR once this lands that drops Node.js 8.x support that can sit around until the project is ready for it.

Just to close the loop on this, here's my promised PR: #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants