Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 10+ #222

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Require Node.js 10+ #222

merged 1 commit into from
Dec 22, 2020

Conversation

westy92
Copy link
Contributor

@westy92 westy92 commented Dec 3, 2020

Drop support for Node.js 8, which is no longer supported: https://nodejs.org/en/about/releases/

@brendankenny
Copy link
Member

Should we drop support for node 10 as well? Node 12 is already the "Maintenance LTS" and 10 goes EoL in April.

https://nodejs.org/en/about/releases/

Would let us get rid of rimraf as a dep at some point, which would be kind of nice.

@westy92
Copy link
Contributor Author

westy92 commented Dec 22, 2020

@brendankenny IMO Node 10 support shouldn't be dropped until April 30th when it reaches EoL, but that's not my decision to make.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

@paulirish paulirish merged commit 83ab178 into GoogleChrome:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants