-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA category refactor tracking issue #6395
Comments
Suggesting 'Optimized' in the place of 'Engaging' |
And we landed on "PWA Optimized" |
What about 'Enhancements'? |
Refinements |
I'm hoping the word is useful when we say something like, "Making it Reliable and Fast, Installable, and PWA Optimized can help your app provide a great app experience." |
Hmm... But isn't it a little redundant because it's already in the PWA section? |
FWIW, here are some of my thoughts. That section is a grab-bag of things that make the app feel not terrible. They're baseline things that make it more like how a professional, well-put-together, native-like app would feel. These are the words that come to my mind when I think about the audits in there Usable |
Hoping it to feel more action-oriented i.e. [the word] is done to the app by the developer. Would 'Refined' work? |
I went with "PWA Optimized" for now as a compromise, but I'll throw my vote in for "Polished" as well :)
We'll need to do this fairly quickly, since we'll want to have it locked down by 4.0 (so, this week :). We can have a different group name from group id and so be able to change what's displayed in the future, but it would be nice to have them not too far apart. |
From CR in #6486: I feel like a fill of Top is current, middle matches all other icon fill colors, bottom is a softer grey. |
|
Ooooooo "Polished" is exactly what I was searching for :) |
"Polished" seems to have a notion of perception by others (i.e. feels judged a bit). |
@hwikyounglee commented in #6526
Agreed, the only issue is the other categories and if they should have similar spacing. I know it was requested to keep the perf section more compact, for instance, but it feels weird for them to have different spacing around their group icons |
Alternative idea: |
re: vertical spacing +1 to using the same spacing for other categories. Vertical spacing could help with seeing a long list with visual grouping. |
ok, great. I'll add it to the list 👍 |
💥 💥 💥 💥 |
New groupings:
Fast and Reliable
Installable
start_url
is in SW scope core(service-worker): check that start_url is within SW's scope #6678PWA Optimized
should be in a different group?(deferring question for now)Manual
Next:
Lighthouse v5
The text was updated successfully, but these errors were encountered: