report(pwa): add tooltip to badge gauge #6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Dec 3, 2018
|
|
||
| const tips = []; | ||
| for (const groupId of groupIds) { | ||
| const groupAudits = auditRefs.filter(ref => ref.group === groupId); |
There was a problem hiding this comment.
nit: groupAuditRefs or .map(ref => ref.result)
There was a problem hiding this comment.
groupAuditRefs
done
| assert.ok(gaugeElem.classList.contains('lh-badged--all')); | ||
|
|
||
| // All tooltips should have x/x audits passed. | ||
| const tips = gaugeElem.title.split(', '); |
There was a problem hiding this comment.
should we assert any length here?
There was a problem hiding this comment.
should we assert any length here?
good idea, done
|
lg |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last item in #6395!
Adds a tooltip as discussed in #6395 (comment) and comments below that.
Was a little more work than expected because we needed
categoryGroupspiped through to get their titles, but not too bad since they were mostly already nearby.