misc: release script push tag #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Jan 8, 2020
| @@ -17,7 +17,7 @@ fi | |||
|
|
|||
| OLD_VERSION=$(node -e "console.log(require('./package.json').version)") | |||
| NEW_VERSION=$1 | |||
| BRANCH_NAME="bump_$NEW_VERSION" | |||
| BRANCH_NAME="v$NEW_VERSION" | |||
There was a problem hiding this comment.
will this conflict with actual tags in any way? I always avoided naming my branch something that I plan to tag so it's always unambiguous but it could just be a git boogeyman I inherited
There was a problem hiding this comment.
nothing technical. just in your head :)
There was a problem hiding this comment.
nothing technical. just in your head :)
LIES!
➜ git-tag git init
Initialized empty Git repository
➜ git-tag git:(master) touch foo
➜ git-tag git:(master) ✗ git add -A
➜ git-tag git:(master) ✗ git commit -m 'foo'
[master (root-commit) 6079296] foo
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 foo
➜ git-tag git:(master) git checkout -b v1.0.0
Switched to a new branch 'v1.0.0'
➜ git-tag git:(v1.0.0) touch bar ➜ git-tag git:(v1.0.0) ✗ git add -A
➜ git-tag git:(v1.0.0) ✗ git commit -m 'bar'
[v1.0.0 cd7d050] bar
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 bar
➜ git-tag git:(v1.0.0) git checkout master
Switched to branch 'master'
➜ git-tag git:(master) git tag -a v1.0.0 -m 'version tag'
➜ git-tag git:(master) touch baz
➜ git-tag git:(master) ✗ git add -A
➜ git-tag git:(master) ✗ git commit -m 'baz'
[master 0df3345] baz
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 baz
➜ git-tag git:(master) git checkout v1.0.0
warning: refname 'v1.0.0' is ambiguous.
Switched to branch 'v1.0.0'
There was a problem hiding this comment.
ok i'll just do the other thing in this pr.
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple items from #9857