deps(typescript): update to 3.8.3 #10461

connorjclark · 2020-03-13T23:09:15Z

~~3.5.3 -> 3.7.5 (3.6.* had no errors, 3.8.* had a few more)~~

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#37-breaking-changes
EDIT: ooooh their new design is dark by default https://www.typescriptlang.org/v2/docs/handbook/release-notes/typescript-3-7.html

change an Object to any.
global type behavior for renderer code changed:

if (typeof module !== 'undefined' && module.exports) {
  // Just for testing in node...
  module.exports = DetailsRenderer;
} else {
  // Used to add in global types
  self.DetailsRenderer = DetailsRenderer;
}

Works again if just self.DetailsRenderer = DetailsRenderer;. Tried a few different variants of what we have today, but it seems that any setting of module.exports (despite if guards) causes the module to not be globally resolvable. So, let's just be more explicit and import them as needed (which we do already in other files ....):

/** @typedef {import('./details-renderer.js')} DetailsRenderer */

brendankenny

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#37-breaking-changes

change an Object to any.

It me :) microsoft/TypeScript#32829

global type behavior for renderer code changed:

So, let's just be more explicit and import them as needed (which we do already in other files ....):
/** @typedef {import('./details-renderer.js')} DetailsRenderer */

Ah, this is way better. I believe this means you can also delete this whole chunk of declarations:

lighthouse/types/html-renderer.d.ts

Lines 36 to 49 in 72f0774

    
           interface Window { 
        
             CategoryRenderer: typeof _CategoryRenderer; 
        
             CriticalRequestChainRenderer: typeof _CriticalRequestChainRenderer; 
        
             SnippetRenderer: typeof _SnippetRenderer; 
        
             DetailsRenderer: typeof _DetailsRenderer; 
        
             DOM: typeof _DOM; 
        
             I18n: typeof _I18n; 
        
             PerformanceCategoryRenderer: typeof _PerformanceCategoryRenderer; 
        
             PwaCategoryRenderer: typeof _PwaCategoryRenderer; 
        
             ReportRenderer: typeof _ReportRenderer; 
        
             ReportUIFeatures: typeof _ReportUIFeatures; 
        
             Util: typeof _Util; 
        
             prepareLabData: typeof _prepareLabData; 
        
           }

(the global ones have to stick around, though)

brendankenny · 2020-03-18T19:58:13Z

lighthouse-core/computed/metrics/lantern-estimated-input-latency.js

@@ -42,7 +42,7 @@ class LanternEstimatedInputLatency extends LanternMetric {

  /**
   * @param {LH.Gatherer.Simulation.Result} simulation
-   * @param {Object} extras
+   * @param {any} extras


we're not dealing with these safely anyways, and unfortunately the templated-class solution doesn't work in tsc because these are static methods, so what do you think of one of

using @param {{optimistic: boolean}} extras here (and in the other lantern metrics) and @ts-ignore on the two accesses below or

typing extras exactly as what's used and @ts-ignore the call to getEstimateFromSimulation in lantern-metric.js

I think the intent is clearer either way, and it gives a clearer TODO of what needs to be resolved (on our side or the tsc side) to get extras properly checked.

lighthouse-core/lib/cdt/SDK.js

lighthouse-core/test/gather/gather-runner-test.js

brendankenny · 2020-03-18T20:39:58Z

3.5.3 -> 3.7.5 (3.6.* had no errors, 3.8.* had a few more)

Why not go all the way to 3.8.3? Seems better to do it all if we're going to make an upgrade

connorjclark · 2020-03-18T22:09:43Z

Why not go all the way to 3.8.3? Seems better to do it all if we're going to make an upgrade

Just trying to keep the PR smaller. We can do it all at once if you like.

brendankenny · 2020-03-18T22:21:25Z

Why not go all the way to 3.8.3? Seems better to do it all if we're going to make an upgrade

Just trying to keep the PR smaller. We can do it all at once if you like.

probably makes sense? It seems like most of the 3.8 errors can also be fixed in a few lines. Could be separate commits for easier reviewing 🤷‍♀

connorjclark · 2020-03-19T02:12:31Z

It me :) microsoft/TypeScript#32829

wow big props for making a TS change.

weird, says that was for 3.8 but i saw breakage in 3.7

Updated to 3.8.3

Co-Authored-By: Brendan Kenny <bckenny@gmail.com>

…tsc-update

brendankenny · 2020-03-19T19:30:14Z

lighthouse-core/test/gather/driver-test.js

@@ -512,6 +512,7 @@ describe('.gotoURL', () => {
    }
    const replayConnection = new ReplayConnection();

+    // @ts-ignore: Coerce to TestDriver for looser typing in function parameters.


since this is a real driver, it seems a little weird to cast to a fake driver type :)

One option: could ts-ignore an assertion on loadOptions instead

const loadOptions = { waitForLoad: true, /** @type {LH.Gatherer.PassContext} */ // @ts-ignore - we don't need the entire context for the test. passContext: { passConfig: { pauseAfterLoadMs: 0, networkQuietThresholdMs: 0, cpuQuietThresholdMs: 0, }, }, };

(though we should probably eventually have a passContext generator if we're really getting all real in this file)

brendankenny · 2020-03-19T19:30:49Z

lighthouse-core/test/gather/driver-test.js

@@ -133,7 +133,7 @@ async function flushAllTimersAndMicrotasks(ms = 1000) {
 * @property {(...args: RecursivePartial<Parameters<Driver['goOnline']>>) => ReturnType<Driver['goOnline']>} goOnline
 */

-/** @typedef {Driver & DriverMockMethods} TestDriver */
+/** @typedef {Omit<Driver, keyof DriverMockMethods> & DriverMockMethods} TestDriver */


lighthouse-core/report/html/renderer/snippet-renderer.js

brendankenny · 2020-03-19T19:34:28Z

lighthouse-core/computed/metrics/lantern-metric.js

+ * @property {LH.Artifacts.LanternMetric} fcpResult
+ * @property {LH.Artifacts.LanternMetric} fmpResult
+ * @property {LH.Artifacts.LanternMetric} interactiveResult
+ * @property {{speedIndex: number}} speedline


should these all (except optimistic) be optional, though?

lighthouse-core/computed/metrics/lantern-metric.js

brendankenny · 2020-04-07T15:55:10Z

@connorjclark any news? tsc 3.9 release is creeping up fast :)

brendankenny

LGTM! ⌨️☑️

brendankenny · 2020-04-08T16:27:25Z

lighthouse-core/computed/metrics/lantern-metric.js

@@ -85,7 +94,7 @@ class LanternMetricArtifact {
  /**
   * @param {LH.Artifacts.MetricComputationDataInput} data
   * @param {LH.Audit.Context} context
-   * @param {any=} extras
+   * @param {Omit<Extras, 'optimistic'>=} extras


since requirements aren't changing very quickly any more, at some point we should take a pass at these extras to see if we can untangle them a bit :)

connorjclark requested a review from a team as a code owner March 13, 2020 23:09

connorjclark requested review from brendankenny and removed request for a team March 13, 2020 23:09

googlebot added the cla: yes label Mar 13, 2020

vercel bot deployed to Preview March 13, 2020 23:10 View deployment

devtools-bot assigned brendankenny Mar 13, 2020

devtools-bot added the waiting4reviewer label Mar 13, 2020

brendankenny reviewed Mar 18, 2020

View reviewed changes

deps(typescript): update to 3.7.5

9681400

connorjclark force-pushed the tsc-update branch from 867a900 to 9681400 Compare March 19, 2020 01:55

vercel bot deployed to Preview March 19, 2020 01:55 View deployment

deps(typescript): update to 3.8.3

2cf1540

vercel bot deployed to Preview March 19, 2020 02:08 View deployment

connorjclark changed the title ~~deps(typescript): update to 3.7.5~~ deps(typescript): update to 3.8.3 Mar 19, 2020

Apply suggestions from code review

2c118bd

Co-Authored-By: Brendan Kenny <bckenny@gmail.com>

vercel bot deployed to Preview March 19, 2020 02:15 View deployment

connorjclark added 2 commits March 18, 2020 19:28

extras

9e6e3da

Merge branch 'tsc-update' of github.com:GoogleChrome/lighthouse into …

edf6f8c

…tsc-update

vercel bot deployed to Preview March 19, 2020 02:29 View deployment

brendankenny reviewed Mar 19, 2020

View reviewed changes

no protect

b76acd7

vercel bot deployed to Preview March 20, 2020 23:08 View deployment

brendankenny added waiting4committer and removed waiting4reviewer labels Mar 23, 2020

Merge remote-tracking branch 'origin/master' into tsc-update

c83c816

pr

4e77bec

vercel bot deployed to Preview April 8, 2020 03:01 View deployment

pr

ec03206

vercel bot deployed to Preview April 8, 2020 03:04 View deployment

brendankenny approved these changes Apr 8, 2020

View reviewed changes

brendankenny mentioned this pull request Apr 8, 2020

core(runner): make LH.Audit.Context immutable #10555

Merged

brendankenny merged commit 4f6170d into master Apr 8, 2020

brendankenny deleted the tsc-update branch April 8, 2020 18:38

brendankenny mentioned this pull request Apr 13, 2020

core(lantern): improve LCP tail error #10529

Merged

paulirish pushed a commit that referenced this pull request Apr 14, 2020

deps(typescript): update to 3.8.3 (#10461)

b950f6d

brendankenny mentioned this pull request Apr 14, 2020

Errors when running tests locally #10582

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps(typescript): update to 3.8.3 #10461

deps(typescript): update to 3.8.3 #10461

connorjclark commented Mar 13, 2020 •

edited by brendankenny

Loading

brendankenny left a comment •

edited

Loading

brendankenny Mar 18, 2020

brendankenny commented Mar 18, 2020

connorjclark commented Mar 18, 2020

brendankenny commented Mar 18, 2020

connorjclark commented Mar 19, 2020

brendankenny Mar 19, 2020 •

edited

Loading

brendankenny Mar 19, 2020

brendankenny Mar 19, 2020

connorjclark Apr 8, 2020

brendankenny commented Apr 7, 2020

brendankenny left a comment

brendankenny Apr 8, 2020

	interface Window {
	CategoryRenderer: typeof _CategoryRenderer;
	CriticalRequestChainRenderer: typeof _CriticalRequestChainRenderer;
	SnippetRenderer: typeof _SnippetRenderer;
	DetailsRenderer: typeof _DetailsRenderer;
	DOM: typeof _DOM;
	I18n: typeof _I18n;
	PerformanceCategoryRenderer: typeof _PerformanceCategoryRenderer;
	PwaCategoryRenderer: typeof _PwaCategoryRenderer;
	ReportRenderer: typeof _ReportRenderer;
	ReportUIFeatures: typeof _ReportUIFeatures;
	Util: typeof _Util;
	prepareLabData: typeof _prepareLabData;
	}

deps(typescript): update to 3.8.3 #10461

deps(typescript): update to 3.8.3 #10461

Conversation

connorjclark commented Mar 13, 2020 • edited by brendankenny Loading

brendankenny left a comment • edited Loading

Choose a reason for hiding this comment

brendankenny Mar 18, 2020

Choose a reason for hiding this comment

brendankenny commented Mar 18, 2020

connorjclark commented Mar 18, 2020

brendankenny commented Mar 18, 2020

connorjclark commented Mar 19, 2020

brendankenny Mar 19, 2020 • edited Loading

Choose a reason for hiding this comment

brendankenny Mar 19, 2020

Choose a reason for hiding this comment

brendankenny Mar 19, 2020

Choose a reason for hiding this comment

connorjclark Apr 8, 2020

Choose a reason for hiding this comment

brendankenny commented Apr 7, 2020

brendankenny left a comment

Choose a reason for hiding this comment

brendankenny Apr 8, 2020

Choose a reason for hiding this comment

connorjclark commented Mar 13, 2020 •

edited by brendankenny

Loading

brendankenny left a comment •

edited

Loading

brendankenny Mar 19, 2020 •

edited

Loading