checkJs: require JSDoc type argument for Array, Object, and Promise in noImplicitAny #32829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32766
As discussed in that issue, when
noImplicitAny
is set incheckJs
, this change makes it an error to not specify a type argument in the jsdoc annotations for/** @type {Array} */
,/** @type {Object} */
, and/** @type {Promise} */
the same way it is for all other jsdoc parameterized types.If not
noImplicitAny
, nothing changes and the type argument(s) will continue to default toany
for these three special cases.Also as discussed in #32766 (comment), dropping the
Object -> any
mapping will be a bigger change than the other two types, thoughnoImplicitAny
andstrict
checkJs
projects are out there that will break with this change