-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(scoring): update CLS score curve - 0.25 is now failing #10495
Conversation
lol how does this file have no tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % link update
I'm not sure what's here, so if it matters to the review maybe get a googler's eyes too?
lol how does this file have no tests
FWIW the sample JSON artifact serves the same function as what I imagine would be the lone unit test
// see https://www.desmos.com/calculator/wmcxn7zfhc | ||
scorePODR: 0.02, | ||
scoreMedian: 0.2, | ||
// see https://www.desmos.com/calculator/vjb652sqeh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it didn't save with the new values, maybe just forgot to press save?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -46,9 +46,9 @@ class CumulativeLayoutShift extends Audit { | |||
return { | |||
// Calibrated to assure 0.1 gets a score of 0.9. https://web.dev/cls/#what-is-a-good-cls-score |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should really consider reworking our math so we can define in terms of the 90 cutoff :) haha
it's just a doc of thresholds used for field data too
substitute "this file" with "these files" to include the computed artifact too :) |
conflicts though :) |
keeping up with the joneses.
CLS of 0.25 and above is now considered failing
tweak the PODR to make sure CLS 0.10 is still a score of 90/100
https://goto.google.com/tbsgg