Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(scoring): update CLS score curve - 0.25 is now failing #10495

Merged
merged 5 commits into from
Apr 28, 2020
Merged

core(scoring): update CLS score curve - 0.25 is now failing #10495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99a37a2
core(scoring): update CLS scorecuve - 0.25 is now failing
paulirish Mar 23, 2020
355f25f
json
paulirish Mar 23, 2020
b52c7d2
update desmos link
paulirish Apr 28, 2020
cd81ddf
Merge branch 'master' into clsscurve
paulirish Apr 28, 2020
5601bca
Merge branch 'master' into clsscurve
paulirish Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/audits/metrics/cumulative-layout-shift.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ class CumulativeLayoutShift extends Audit {
return {
// Calibrated to assure 0.1 gets a score of 0.9. https://web.dev/cls/#what-is-a-good-cls-score
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should really consider reworking our math so we can define in terms of the 90 cutoff :) haha

// This 0.1 target score was determined through both manual evaluation and large-scale analysis.
// see https://www.desmos.com/calculator/wmcxn7zfhc
scorePODR: 0.02,
scoreMedian: 0.2,
// see https://www.desmos.com/calculator/vjb652sqeh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it didn't save with the new values, maybe just forgot to press save?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

true. just updated with the newer shiny one.

scorePODR: 0.054,
scoreMedian: 0.25,
};
}

Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
"id": "cumulative-layout-shift",
"title": "Cumulative Layout Shift",
"description": "Cumulative Layout Shift is the sum of all layout shifts that occurred during a page's load. A layout shift is any movement an element makes once it is visible to the user. All layout shift is recorded, scored, and then aggregated into a cumulative score between 0 and 1; 0 being a perfectly stable page, and >=0.5 being a highly shifting page. [Learn more](https://web.dev/cls).",
"score": 0.21,
"score": 0.23,
"scoreDisplayMode": "numeric",
"numericValue": 0.42,
"numericUnit": "unitless",
Expand Down
2 changes: 1 addition & 1 deletion proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@
"id": "cumulative-layout-shift",
"numericUnit": "unitless",
"numericValue": 0.42,
"score": 0.21,
"score": 0.23,
"scoreDisplayMode": "numeric",
"title": "Cumulative Layout Shift"
},
Expand Down