core(index): update api helpers to use FR #14011
Conversation
|
See the |
| @@ -82,8 +82,46 @@ describe('CLI Tests', function() { | |||
| }); | |||
|
|
|||
| describe('print-config', () => { | |||
| describe('fraggle rock', () => { | |||
There was a problem hiding this comment.
I created a "fraggle rock" block instead of a "legacy" block so the snapshots would be preserved.
| @@ -82,8 +82,46 @@ describe('CLI Tests', function() { | |||
| }); | |||
|
|
|||
| describe('print-config', () => { | |||
| describe('fraggle rock', () => { | |||
| it('should print the default config and exit immediately after', () => { | |||
There was a problem hiding this comment.
Oh man, I didn't realize this snapshot was from a --print-config test. I vote we don't do this one and delete the matching legacy "should print the default config and exit immediately after" and rid ourselves of some of the annoying -u churn in here.
The "overridden config" test below covers the cli flag sufficiently and the print string unit tests are where the real testing is. I feel like this one is just causing snapshot blindness due to the constant updates it needs.
There was a problem hiding this comment.
FWIW this test helped me catch an issue where artifact dependencies were showing up in the printed config even though dependencies aren't declared in the config json.
That condition can be added to a more specific test though so I could go either way.
There was a problem hiding this comment.
That condition can be added to a more specific test though so I could go either way.
Maybe could do --only-audits charset instead of metrics in the test below this? That should require MainDocumentContent which depends on DevtoolsLog.
Follow up to #13783.