Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(index): update api helpers to use FR #14011

Merged
merged 11 commits into from
Jun 22, 2022
Merged

core(index): update api helpers to use FR #14011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
20fb22e
start
adamraine May 9, 2022
c6711af
test
adamraine May 16, 2022
c1fe4a2
tests
adamraine May 17, 2022
c90f96a
Merge branch 'master' into node-api-helpers-fr
adamraine May 17, 2022
027a12a
fps
adamraine May 17, 2022
1526c65
rm tests
adamraine May 17, 2022
ed53683
ok
adamraine May 17, 2022
c6ef26d
Merge branch 'master' into node-api-helpers-fr
adamraine Jun 22, 2022
2b1b762
test
adamraine Jun 22, 2022
74b3e16
no async
adamraine Jun 22, 2022
6382eaa
Merge branch 'master' into node-api-helpers-fr
adamraine Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lighthouse-cli/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import {runLighthouse} from './run.js';
import lighthouse from '../lighthouse-core/index.js';
import {askPermission} from './sentry-prompt.js';
import {LH_ROOT} from '../root.js';
import {getConfigDisplayString} from '../lighthouse-core/fraggle-rock/config/config.js';

const pkg = JSON.parse(fs.readFileSync(LH_ROOT + '/package.json', 'utf-8'));

Expand Down Expand Up @@ -120,8 +121,13 @@ async function begin() {
}

if (cliFlags.printConfig) {
const config = await lighthouse.generateConfig(configJson, cliFlags);
process.stdout.write(config.getPrintString());
if (cliFlags.legacyNavigation) {
const config = await lighthouse.generateLegacyConfig(configJson, cliFlags);
process.stdout.write(config.getPrintString());
} else {
const config = await lighthouse.generateConfig(configJson, cliFlags);
process.stdout.write(getConfigDisplayString(config));
}
return;
}

Expand Down
Loading