-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_audit: entity-classification #14614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamraine
reviewed
Dec 22, 2022
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
15 tasks
Closing this in favor of #14622. All the review changes made here should've made it to that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #14440 and the design doc, this PR introduces an
entity-classification
audit that classifies all 1st and 3rd party entities (recognized bythird-party-web
and unrecognized) and exposes them in LHR as an informative audit. By and large, this achieves a few important things:details.items
withentity
names. This will allow JSON consumers / HTTPArchive users to query and aggregate items by entity names. For example, one could query What % of unused JavaScript is shipped by "Google Ads" entity?, without having to worry about aggregating all URLs used by that entity.Other notes:
entity-classification
ordetails.item.entity
attribute), third-party filters will continue using origin string match logic as a fallback.Util.getRootDomain
. In future, we could explore joining different first-party root domains into a single entity via First-Party Sets and reduce any over-aggregation via Public Suffix List.