Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config rebuild: keep defaultPass #2671

Merged
merged 1 commit into from
Jul 11, 2017
Merged

config rebuild: keep defaultPass #2671

merged 1 commit into from
Jul 11, 2017

Conversation

paulirish
Copy link
Member

example config:

module.exports = {
  "extends": "lighthouse:default",
  "settings": {
    "onlyAudits": [
      "is-on-https"
    ]
  }
}

This ends up filtering out the defaultPass as there are no audits consuming a trace from it.
There are other ways to fix this.
This is but one.

@@ -540,6 +540,8 @@ class Config {
}).filter(pass => {
// remove any passes lacking concrete gatherers, unless they are dependent on the trace
if (pass.recordTrace) return true;
// Always keep defaultPass
if (pass.passName === 'defaultPass') return true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still partial to checking if they requested the devtoolsLog artifact for keeping it, but that only applies to like 2 audits so I'm cool with this too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still partial to checking if they requested the devtoolsLog artifact for keeping it

yeah, that would have gotten us closer to where we need to be wrt to ditching defaultPass.

Also needs a test :P

@patrickhulce patrickhulce merged commit 78e761a into master Jul 11, 2017
@patrickhulce patrickhulce deleted the confighas1pass branch July 11, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants