Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config rebuild: keep defaultPass #2671

Merged
merged 1 commit into from
Jul 11, 2017
Merged

config rebuild: keep defaultPass #2671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lighthouse-core/config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,8 @@ class Config {
}).filter(pass => {
// remove any passes lacking concrete gatherers, unless they are dependent on the trace
if (pass.recordTrace) return true;
// Always keep defaultPass
if (pass.passName === 'defaultPass') return true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still partial to checking if they requested the devtoolsLog artifact for keeping it, but that only applies to like 2 audits so I'm cool with this too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still partial to checking if they requested the devtoolsLog artifact for keeping it

yeah, that would have gotten us closer to where we need to be wrt to ditching defaultPass.

Also needs a test :P

return pass.gatherers.length > 0;
});
return filteredPasses;
Expand Down