feat: add base fast mode config #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jul 17, 2017
|
done! |
paulirish
reviewed
Jul 17, 2017
| pauseAfterLoadMs: 0, | ||
| networkQuietThresholdMs: 500, | ||
| cpuQuietThresholdMs: 500, | ||
| gatherers: [], |
There was a problem hiding this comment.
this is kinda confusing.
passName above makes sure this will "overwrite" the default defaultPass definition. And indeed the 29-32 properties overwrite.
But the array is concat'd so the default gatherers are still included.
Can we add a short comment here to explain what's going on? Or augment configuration.md and link to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the name of FastMode (#2703)
starting point for the FastMode config that I'll be adding to/burning down on for fast mode work