Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base fast mode config #2702

Merged
merged 1 commit into from
Jul 17, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions lighthouse-core/config/fast-config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/**
* @license Copyright 2017 Google Inc. All Rights Reserved.
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
*/
'use strict';

module.exports = {
extends: 'lighthouse:default',
settings: {
skipAudits: [
// disabled for now because they are too slow
'no-mutation-events',
'uses-optimized-images',
'uses-webp-images',
'speed-index-metric',
'screenshot-thumbnails',

// disabled for now because their results are not meaningful/cannot be computed anymore
'first-interactive',
'consistently-interactive',
'offscreen-images',
'load-fast-enough-for-pwa',
],
},
passes: [
{
passName: 'defaultPass',
useThrottling: false,
pauseAfterLoadMs: 0,
networkQuietThresholdMs: 500,
cpuQuietThresholdMs: 500,
gatherers: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is kinda confusing.

passName above makes sure this will "overwrite" the default defaultPass definition. And indeed the 29-32 properties overwrite.
But the array is concat'd so the default gatherers are still included.

Can we add a short comment here to explain what's going on? Or augment configuration.md and link to that.

},
],
};