core(gather): define new DNS failure LH Error #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested review from
brendankenny and
patrickhulce
as code owners
patrickhulce
suggested changes
Nov 16, 2018
| @@ -182,6 +182,13 @@ const ERRORS = { | |||
| lhrRuntimeError: true, | |||
| }, | |||
|
|
|||
| // Protocol timeout failures | |||
| DNS_FAILURE: { | |||
exterkamp
previously requested changes
Nov 16, 2018
|
ptal |
brendankenny
approved these changes
Nov 16, 2018
proto/lighthouse-result.proto
Outdated
| @@ -49,6 +49,8 @@ enum LighthouseError { | |||
| PROTOCOL_TIMEOUT = 17; | |||
| // Used when the page is not responding after maxWaitForLoad. | |||
| PAGE_HUNG = 18; | |||
| // DNS timed out for the main document request. | |||
There was a problem hiding this comment.
handles more cases than just a timeout?
| // https://cs.chromium.org/chromium/src/net/base/net_error_list.h?rcl=cd62979b | ||
| if ( | ||
| netErr.startsWith('net::ERR_NAME_NOT_RESOLVED') || | ||
| netErr.startsWith('net::ERR_NAME_RESOLUTION_FAILED') || |
There was a problem hiding this comment.
just test equality for these two? Or are these expected as prefixes?
| netErr.startsWith('net::ERR_DNS_') | ||
| ) { | ||
| errorDef = {...LHError.errors.DNS_FAILURE}; | ||
| } else { |
There was a problem hiding this comment.
these conditionals are multiplying in an unseemly fashion. Maybe #6457 can take on cleaning them up with early returns @exterkamp
| netErr.startsWith('net::ERR_NAME_RESOLUTION_FAILED') || | ||
| netErr.startsWith('net::ERR_DNS_') | ||
| ) { | ||
| errorDef = {...LHError.errors.DNS_FAILURE}; |
There was a problem hiding this comment.
if no string/message altering, no need to object spread to get a copy (e.g. see NO_DOCUMENT_REQUEST above)
| // Wrap gatherer response in promise, whether rejected or not. | ||
| Promise.resolve().then(_ => gatherer.afterPass(passContext, passData)); | ||
| const artifactPromise = pageLoadError | ||
| ? Promise.reject(pageLoadError) |
There was a problem hiding this comment.
did prettier get loose? This is bad (I'm surprised we don't lint it) and the concat thing above is definitely worse :)
There was a problem hiding this comment.
prettier! get back in your cage.
patrickhulce
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing a lot of these errors. I think we want to expose them to the user individually.