-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(gather): define new DNS failure LH Error #6579
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5b7c403
core(gather): define new DNS failure LH Error
paulirish 32476eb
update proto
paulirish 20c104c
consider all resolution/dns net errors
paulirish e2eb323
tests
paulirish 803d334
Merge branch 'master' into dns
paulirish 5ac35a0
thx
paulirish 69e0d49
go home prettier, you're drunk.
paulirish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,8 +150,12 @@ class GatherRunner { | |
if (!mainRecord) { | ||
errorDef = LHError.errors.NO_DOCUMENT_REQUEST; | ||
} else if (mainRecord.failed) { | ||
errorDef = {...LHError.errors.FAILED_DOCUMENT_REQUEST}; | ||
errorDef.message += ` ${mainRecord.localizedFailDescription}.`; | ||
if (mainRecord.localizedFailDescription === 'net::ERR_NAME_NOT_RESOLVED') { | ||
errorDef = {...LHError.errors.DNS_FAILURE}; | ||
} else { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these conditionals are multiplying in an unseemly fashion. Maybe #6457 can take on cleaning them up with early returns @exterkamp |
||
errorDef = {...LHError.errors.FAILED_DOCUMENT_REQUEST}; | ||
errorDef.message += ` ${mainRecord.localizedFailDescription}.`; | ||
} | ||
} else if (mainRecord.hasErrorStatusCode()) { | ||
errorDef = {...LHError.errors.ERRORED_DOCUMENT_REQUEST}; | ||
errorDef.message += ` Status code: ${mainRecord.statusCode}.`; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,6 +182,13 @@ const ERRORS = { | |
lhrRuntimeError: true, | ||
}, | ||
|
||
// Protocol timeout failures | ||
DNS_FAILURE: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. proto update :) |
||
code: 'DNS_FAILURE', | ||
message: strings.dnsFailure, | ||
lhrRuntimeError: true, | ||
}, | ||
|
||
// Hey! When adding a new error type, update lighthouse-result.proto too. | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if no string/message altering, no need to object spread to get a copy (e.g. see
NO_DOCUMENT_REQUEST
above)