Support for the new webpack v4 plugin architecture. #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeff could you have tests that have a package.json file, run npm install and then run our plugins against a webpack config? Just as a smoke test would be helpful. |
gauntface
approved these changes
Feb 2, 2018
|
Coming up with a reasonable way to test across webpack v3 and v4 is tracked in #1281. Given that it would be nice to make this available to folks currently trying out webpack v4 sooner rather than later, I'm going to merge and we can follow-up there. |
|
Thanks for all the support here! 💪
…On Mon, Feb 5, 2018, 10:25 AM Jeffrey Posnick ***@***.***> wrote:
Merged #1275 <#1275>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1275 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADQBMAMRuhFcCrX7_k8W4SwkZaj_pJ2Vks5tR0ecgaJpZM4R3Xd5>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
CC: @goldhand @TheLarkInn
Fixes #1151
I'd like to get this out there in the next release to at least ensure that folks who are early adopters of webpack v4 get a chance to try it out in real-world scenarios. It's a small change that should be backwards compatible with users still on webpack v3.
This has been a bit hard to test manually, since most of our webpack integration tests rely on other plugins that aren't yet webpack v4 compatible. I did some manual tests of basic compilations using the latest webpack v4 beta, and it seemed to work, though.
I'm also not sure how we could update our tests to work with both webpack v3 and v4, along with the corresponding versions of plugins that are compatible with each. The strategy moving forward might be just to keep our tests against webpack v3 for now, and migrate to testing against webpack v4 once that is fully released and gets some traction.