Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for webpack4 #138

Merged
merged 1 commit into from
Feb 22, 2018
Merged

add support for webpack4 #138

merged 1 commit into from
Feb 22, 2018

Conversation

andriijas
Copy link
Contributor

@andriijas andriijas commented Feb 8, 2018

eliminates deprecation warnings in webpack 4 by feature detecting the new plugin system coming in webpack 4.

webpack 4 is released in about 2 weeks.

fixes #135

@jeffposnick
Copy link

(@goldhand, this is the same approach we implemented in GoogleChrome/workbox#1275.)

@goldhand goldhand merged commit 25beca4 into goldhand:master Feb 22, 2018
@alexander-akait
Copy link

@goldhand maybe also do patch release to avoid output deprecations?

@andriijas
Copy link
Contributor Author

@evilebottnawi its coming soon. see #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 4 support
4 participants