Align navigation with the spec #2856
Labels
Comments
This was referenced Dec 3, 2024
Merged
sadym-chromium
added a commit
that referenced
this issue
Dec 9, 2024
Move navigation logic to NavigationTracker. First step for addressing #2856. No logical changes are expected, simply moved the logic to a dedicated class.
sadym-chromium
added a commit
that referenced
this issue
Dec 11, 2024
Implementation of [Alternative 3. Rely on “Network.requestWillBeSent” CDP event](http://goto.google.com/webdriver:detect-navigation-started#bookmark=id.64balpqrmadv). Required for #2856. Emit `frameStartedNavigating` event on CdpTarget before `Network.requestWillBeSent`.
sadym-chromium
added a commit
that referenced
this issue
Dec 16, 2024
Addressing [Align navigation with the spec](#2856). Navigation tracker relies on the following events: * `Page.frameNavigated` * TargetEvents.FrameStartedNavigating (`Network.requestWillBeSent`) * `Page.navigatedWithinDocument` * `Page.frameRequestedNavigation` * `Page.javascriptDialogOpening:beforeunload` --------- Co-authored-by: browser-automation-bot <133232582+browser-automation-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the navigation events are based on some CDP heuristics, which do not always allow for proper events emitting and commands results.
Related documents
WPT
browsingContext.navigatebrowsingContext.navigationStartedbrowsingContext.navigationAbortedThe text was updated successfully, but these errors were encountered: