-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor navigation #2881
Conversation
6b71d29
to
7f50236
Compare
There are a few new Puppeteer failures as well as far as I can see. |
ba31234
to
b506b68
Compare
The following Puppeteer tests are new regressions with this PR:
|
752d25a
to
8e71934
Compare
I have landed the roll with existing changes into Puppeteer so that new regressions are clear. If anything fails in the Puppeteer job now, it is caused by the changes in this PR. |
I'd suggest we add e2e tests/fixes for Puppeteer scenarios that this change affects. |
"[oopif.spec] OOPIF should load oopif iframes with subresources and request interception" seems to be a Linux-only failure upstream. |
2bb265e
to
14f5df6
Compare
a9bb606
to
c47a4e6
Compare
c47a4e6
to
0bf727c
Compare
Addressing Align navigation with the spec.
Navigation tracker relies on the following events:
Page.frameNavigated
Network.requestWillBeSent
)Page.navigatedWithinDocument
Page.frameRequestedNavigation
Page.javascriptDialogOpening:beforeunload
BEGIN_COMMIT_OVERRIDE
fix!: align navigation started with the spec
END_COMMIT_OVERRIDE