Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement network.responseStarted event #765

Closed
2 tasks done
thiagowfx opened this issue May 23, 2023 · 1 comment · Fixed by #1497 or #1460
Closed
2 tasks done

Implement network.responseStarted event #765

thiagowfx opened this issue May 23, 2023 · 1 comment · Fixed by #1497 or #1460
Assignees
@thiagowfx

Comments

@thiagowfx
Copy link
Contributor

thiagowfx commented May 23, 2023 •
edited
Loading

Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted

Tracking
@thiagowfx thiagowfx changed the title Implement network. responseStarted event Implement network.responseStarted event May 23, 2023
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
4712e66 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
79d29a2 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
6cb1f96 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
59c05a7 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
78a469b 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
6a2cc27 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
ca811b3 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec
22ba697 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
1cb0e8a 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
abf07a2 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
aa60ecc 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
31e6e5b 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
5b905bd 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
266053a 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
7160532 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
69b4e70 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
2dcb6f5 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
e2be28a 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
0737f64 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
e616703 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 23, 2023
align network module with BiDi spec and scaffold responseStarted
bf2faf0 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
@thiagowfx thiagowfx mentioned this issue May 23, 2023
Merged
thiagowfx pushed a commit that referenced this issue May 24, 2023
align network module with BiDi spec and scaffold responseStarted
ba2bd73 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 24, 2023
align network module with BiDi spec and scaffold responseStarted
29838d2 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 24, 2023
align network module with BiDi spec and scaffold responseStarted
a33174a 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 25, 2023
align network module with BiDi spec and scaffold responseStarted
dd8c6bf 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 25, 2023
align network module with BiDi spec and scaffold responseStarted
1782c67 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 25, 2023
align network module with BiDi spec and scaffold responseStarted
61f8cad 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 25, 2023
align network module with BiDi spec and scaffold responseStarted
def16a2 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
thiagowfx pushed a commit that referenced this issue May 26, 2023
network: miscellaneous changes (#764)
7085b2d 
* network: verify `fromCache` field is correct

Verified it matches the CDP/DevTools implementation:

  cached(): boolean {
    return (Boolean(this.#fromMemoryCache) || Boolean(this.#fromDiskCache)) && !this.#transferSizeInternal;
  }

* align network module with BiDi spec and scaffold responseStarted

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network
@thiagowfx thiagowfx mentioned this issue May 30, 2023
Merged
thiagowfx pushed a commit that referenced this issue May 30, 2023
remove tlsEnd from FetchTimingInfo in network module
ee54f5c 
It is not present in the spec: https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo

Bug: #765
@thiagowfx
Copy link
Contributor Author

See w3c/webdriver-bidi#204 (comment).

@thiagowfx thiagowfx self-assigned this May 31, 2023
thiagowfx pushed a commit that referenced this issue Jun 20, 2023
network: populate response headers size
39374d8 
Note: In the absence of WPT tests that verify this field, it may be
slightly off by a few bytes.

Bug: #765
@thiagowfx thiagowfx mentioned this issue Jun 20, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jun 28, 2023
network: populate response headers size
164b82e 
Note: In the absence of WPT tests that verify this field, it may be
slightly off by a few bytes.

Bug: #765
thiagowfx pushed a commit that referenced this issue Jun 28, 2023
network: populate response headers size (#875)
28d0489 
Note: In the absence of WPT tests that verify this field, it may be
slightly off by a few bytes.

Bug: #765
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
d3f3e4b 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
@thiagowfx thiagowfx mentioned this issue Oct 27, 2023
Closed
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
44fb7ad 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
cd9da0c 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
fb82ac8 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
46c84ee 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
e29d068 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 27, 2023
feat(network): emit responseStarted event
95a07b6 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 29, 2023
feat(network): emit responseStarted event
7e445ab 
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 30, 2023
feat(network): emit responseStarted event
12a0863 
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
@thiagowfx thiagowfx mentioned this issue Oct 30, 2023
Merged
thiagowfx pushed a commit that referenced this issue Oct 30, 2023
feat(network): emit responseStarted event
1c4a9e3 
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 30, 2023
feat(network): emit responseStarted event
1f4f3ed 
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 30, 2023
feat(network): emit responseStarted event
2aa1493 
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
thiagowfx pushed a commit that referenced this issue Oct 30, 2023
feat(network): emit responseStarted event ("AND") (#1497)
46220b7 
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Fixed: #765
Spec:
https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
@release-please release-please bot mentioned this issue Oct 30, 2023
Merged
Lightning00Blade pushed a commit that referenced this issue Oct 30, 2023
@release-please
chore(main): release chromium-bidi 0.4.33 (#1460)
d7c613e 
🤖 I have created a release *beep* *boop*
---


##
[0.4.33](chromium-bidi-v0.4.32...chromium-bidi-v0.4.33)
(2023-10-30)


### Features

* add network intercept continue with auth
([#1470](#1470))
([ad3a95e](ad3a95e)),
closes
[#644](#644)
* addPreloadScript respects new contexts
([#1478](#1478))
([b0e55fa](b0e55fa))
* addPreloadScripts respects contexts param for old contexts
([#1475](#1475))
([0cdde07](0cdde07))
* implement headersSize for network requests
([#1498](#1498))
([e904ee0](e904ee0)),
closes
[#644](#644)
* implement network interception continue response
([#1443](#1443))
([4515d1d](4515d1d)),
closes
[#644](#644)
* implement network interception provide response
([#1457](#1457))
([1eca26e](1eca26e)),
closes
[#644](#644)
* **logging:** pretty print received and sent bidi server messages
([#1490](#1490))
([45fd24e](45fd24e))
* **network intercept:** implement continue with auth (cont.)
([#1484](#1484))
([7cc9358](7cc9358)),
closes
[#644](#644)
* **network intercept:** specify BeforeRequestSent whenever AuthRequi…
([#1494](#1494))
([22eafee](22eafee)),
closes
[#644](#644)
* network request: prioritize response status code over extraInfo
([#1466](#1466))
([d1f3302](d1f3302)),
closes
[#644](#644)
* **network:** emit `responseStarted` event ("AND")
([#1497](#1497))
([46220b7](46220b7)),
closes
[#765](#765)


### Bug Fixes

* Add `window.setSelfTargetId` for backward compatibility with chrome
driver
([#1461](#1461))
([fe98f94](fe98f94))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
thiagowfx pushed a commit that referenced this issue Nov 2, 2023
test(e2e): add test for network.responseStarted
32c6470 
Bug: #765
@thiagowfx thiagowfx mentioned this issue Nov 2, 2023
Merged
thiagowfx pushed a commit that referenced this issue Nov 2, 2023
test(e2e): add test for network.responseStarted (#1519)
d1a9c8e 
Bug: #765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagowfx thiagowfx

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@thiagowfx