Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): emit responseStarted event ("AND") #1497

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx thiagowfx commented Oct 30, 2023

As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the responseCompleted event.

Fixed: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted

@thiagowfx thiagowfx changed the title feat(network): emit responseStarted event feat(network): emit responseStarted event (" Oct 30, 2023
@thiagowfx thiagowfx changed the title feat(network): emit responseStarted event (" feat(network): emit responseStarted event ("AND") Oct 30, 2023
@thiagowfx thiagowfx force-pushed the thiagowfx/response-started-and branch from 12a0863 to 1c4a9e3 Compare October 30, 2023 09:51
@thiagowfx thiagowfx force-pushed the thiagowfx/response-started-and branch from 1c4a9e3 to 1f4f3ed Compare October 30, 2023 10:10
@thiagowfx thiagowfx enabled auto-merge (squash) October 30, 2023 10:10
As CDP does not have a corresponding event
(w3c/webdriver-bidi#435), just mirror the
`responseCompleted` event.

Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#event-network-responseStarted
@thiagowfx thiagowfx force-pushed the thiagowfx/response-started-and branch from 1f4f3ed to 2aa1493 Compare October 30, 2023 10:14
@thiagowfx thiagowfx disabled auto-merge October 30, 2023 10:31
@thiagowfx thiagowfx merged commit 46220b7 into main Oct 30, 2023
13 of 14 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/response-started-and branch October 30, 2023 10:31
Lightning00Blade pushed a commit that referenced this pull request Oct 30, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.33](chromium-bidi-v0.4.32...chromium-bidi-v0.4.33)
(2023-10-30)


### Features

* add network intercept continue with auth
([#1470](#1470))
([ad3a95e](ad3a95e)),
closes
[#644](#644)
* addPreloadScript respects new contexts
([#1478](#1478))
([b0e55fa](b0e55fa))
* addPreloadScripts respects contexts param for old contexts
([#1475](#1475))
([0cdde07](0cdde07))
* implement headersSize for network requests
([#1498](#1498))
([e904ee0](e904ee0)),
closes
[#644](#644)
* implement network interception continue response
([#1443](#1443))
([4515d1d](4515d1d)),
closes
[#644](#644)
* implement network interception provide response
([#1457](#1457))
([1eca26e](1eca26e)),
closes
[#644](#644)
* **logging:** pretty print received and sent bidi server messages
([#1490](#1490))
([45fd24e](45fd24e))
* **network intercept:** implement continue with auth (cont.)
([#1484](#1484))
([7cc9358](7cc9358)),
closes
[#644](#644)
* **network intercept:** specify BeforeRequestSent whenever AuthRequi…
([#1494](#1494))
([22eafee](22eafee)),
closes
[#644](#644)
* network request: prioritize response status code over extraInfo
([#1466](#1466))
([d1f3302](d1f3302)),
closes
[#644](#644)
* **network:** emit `responseStarted` event ("AND")
([#1497](#1497))
([46220b7](46220b7)),
closes
[#765](#765)


### Bug Fixes

* Add `window.setSelfTargetId` for backward compatibility with chrome
driver
([#1461](#1461))
([fe98f94](fe98f94))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement network.responseStarted event
3 participants