feat: abort navigation only after frame navigated #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added
DO NOT MERGE
sadym-chromium
force-pushed
the
sadym/aborted-navigation
branch
from
876ee1e to
10dc5a2
Compare
sadym-chromium
changed the title
OrKoN
approved these changes
Dec 17, 2024
sadym-chromium
force-pushed
the
sadym/aborted-navigation
branch
from
10dc5a2 to
757d409
Compare
sadym-chromium
pushed a commit
that referenced
this pull request
Dec 17, 2024
🤖 I have created a release *beep* *boop* --- ## [0.11.0](chromium-bidi-v0.10.2...chromium-bidi-v0.11.0) (2024-12-17) ### ⚠ BREAKING CHANGES * align navigation started with the spec ### Features * abort navigation only after frame navigated ([#2898](#2898)) ([6c3d406](6c3d406)) ### Bug Fixes * align navigation started with the spec ([960531f](960531f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPT failures are due to the fact Chrome emits
frameNavigatedafter receiving headers.web-platform-tests/wpt#49718