Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wdspec] fix browsingContext.navigationFailed test #49718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Dec 16, 2024

Align webdriver/tests/bidi/browsing_context/navigation_failed/navigation_failed.py:test_with_new_navigation_inside_page and test_with_new_navigation with the spec. Currently, the test are not fully aligned with the spec, as the specific event depends on the document creation step, which in order depends on the fetch status.

When WPT trickles response, it sends headers and adds timeouts before sending the body. However, this does not guarantee the new document will not be created and activated:

E.g. in case of Chromium, the document is created after the headers are received. This makes the discrepancy in the events have to be emitted. If the new document is created, it should be the "browsingContext.navigationAborted" event. If not, it should be "browsingContext.navigationFailed".

@sadym-chromium
Copy link
Contributor Author

sadym-chromium commented Dec 16, 2024

If in WPT we could pause sending back headers as well, we could create tests distinguishing between aborted and failed events.

@sadym-chromium sadym-chromium force-pushed the sadym/navigation-failed branch from f96eee1 to 00100f9 Compare December 17, 2024 09:58
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Dec 17, 2024
WPT failures are due to the fact Chrome emits `frameNavigated` after
receiving headers.
web-platform-tests/wpt#49718
@sadym-chromium sadym-chromium force-pushed the sadym/navigation-failed branch from 00100f9 to 23bf354 Compare December 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants