This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 148
chore(tests): Add cloud ops data tests #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced May 25, 2022
losalex
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change! Left couple of comments - can you please see if you can avoid code duplication in rest of the places?
This was referenced Jun 15, 2022
Closed
Merged
daniel-sanche
added a commit
that referenced
this pull request
Jun 16, 2022
This was referenced Sep 19, 2022
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had an error where no logs, metrics, or other cloud ops data was making it's way into sandbox's Cloud Operations dashboards, making the demo useless. This case was missed by our existing tests
monitoring_integration_test.py
with tests that read from live observability data, to make sure it is availablesandboxctl test
. This will let us run our test suite on fresh environments to make sure everything looks as it should, just like the CI tests doRELEASING.md
, so we remember to check this case in our release process checklistRelated issue: #838