Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

chore(tests): Add cloud ops data tests #932

Merged
merged 35 commits into from
Jun 15, 2022
Merged

chore(tests): Add cloud ops data tests #932

merged 35 commits into from
Jun 15, 2022

Conversation

daniel-sanche
Copy link
Member

@daniel-sanche daniel-sanche commented May 25, 2022

We recently had an error where no logs, metrics, or other cloud ops data was making it's way into sandbox's Cloud Operations dashboards, making the demo useless. This case was missed by our existing tests

  • This PR attempts to fix this by rewriting monitoring_integration_test.py with tests that read from live observability data, to make sure it is available
  • Note that these tests alone would not fix the issue, because our CI test project will always have the proper permissions set up. To help us test live sandbox environments easier, I also added sandboxctl test. This will let us run our test suite on fresh environments to make sure everything looks as it should, just like the CI tests do
  • I also added a note to RELEASING.md, so we remember to check this case in our release process checklist

Related issue: #838

@github-actions
Copy link

Open in Cloud Shell
You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

Copy link

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! Left couple of comments - can you please see if you can avoid code duplication in rest of the places?

tests/monitoring_integration_test.py Outdated Show resolved Hide resolved
tests/monitoring_integration_test.py Show resolved Hide resolved
@daniel-sanche daniel-sanche merged commit 85333c6 into develop Jun 15, 2022
@daniel-sanche daniel-sanche deleted the add_tests branch June 15, 2022 00:10
This was referenced Jun 15, 2022
This was referenced Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants