Release v1.24.0 #1853
Merged
Release v1.24.0 #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change logic of validation:
Instead of piling together all buckets for metric regardless of dimensions scope,
Limit validation logic to at most one QuotaBucket in ConsumerQuotaLimit per requested resource.
This change fixes problem when "default" buckets were always used regardless of finding a better matching bucket.
* Remove option to use Aggregation other than "SUM", can be added in future if needed;
* Change QuotaError rendering to output human readable name instead of metric + dimensions scope;
* Execute API calls in parallel to speed it up.
**Before:**
```
validator "test_resource_requirements" failed:
not enough quota for resource "compute.googleapis.com/disks_total_storage", limit=4096 < requested=10250
not enough quota for resource "compute.googleapis.com/c2_cpus", limit=24 < requested=12004
not enough quota for resource "compute.googleapis.com/c2_cpus" in map[region:us-central1], limit=4800 < requested=12004
not enough quota for resource "compute.googleapis.com/cpus_per_vm_family", limit=0 < requested=1144
not enough quota for resource "compute.googleapis.com/cpus_per_vm_family" in map[region:us-central1], limit=0 < requested=1144
not enough quota for resource "compute.googleapis.com/cpus_per_vm_family" in map[vm_family:H3], limit=176 < requested=1144
not enough quota for resource "compute.googleapis.com/cpus_per_vm_family" in map[region:us-central1 vm_family:H3], limit=440 < requested=1144
not enough quota for resource "compute.googleapis.com/n2_cpus", limit=24 < requested=700
not enough quota for resource "compute.googleapis.com/ssd_total_storage", limit=500 < requested=100500
not enough quota for resource "compute.googleapis.com/ssd_total_storage" in map[region:us-central1], limit=55000 < requested=100500 + usage=10500
```
**After:**
```
validator "test_resource_requirements" failed:
not enough quota "C2 CPUs" as "1/{project}/{region}" in [region:us-central1], limit=4800 < requested=12004
not enough quota "Total SSD disk reserved (GB)" as "1/{project}/{region}" in [region:us-central1], limit=55000 < requested=100500 + usage=10500
not enough quota "CPU count per VM family." as "1/{project}/{region}/{vm_family}" in [region:us-central1 vm_family:H3], limit=440 < requested=1144
```
Added h3_partition quota information to hpc-slurm.yaml
Create simple command line tool to summarize topology of VMs
Exposes new variables in schedmd-slurm-gcp-v5-login, schedmd-slurm-gcp-v5-controller, schedmd-slurm-gcp-v5-hybrid, schedmd-slurm-gcp-v5-node-group and schedmd-slurm-gcp-v5-partition. Also modifed node-groups.yaml, to include the new variable reservation_name.
…t(300) - marking down and power_save
Bump slurm-gcp to 5.8.0 (from 5.7.6)
…ecessary setup lines.
Update the number of partitions created for `hpc-enterprise-slurm.yaml`
…Terraform module to work
Static nodes in cluster partition via OFE
Update develop with release v1.22.1
Enable release integration test
Update Slurm modules to 5.9.1 release from SchedMD
Enable passing of complex variables in integration tests
This commit updates the install_ramble_deps module, by changing the python package name, and using a venv for ramble (as is used in spack). This fixes issues with the ramble module on rocky linux.
Rename tests to match the blueprint names
Update the install ramble deps runner based on the spack module
apt-get update was causing an error during the packer image creation step. An upstream package, specifically `gcsfuse-bullseye`, changed it's Origin and Label. This allows for those values to be updated.
Fix install script in ml-slurm example
Include #1831 on develop branch
Bumping version to 1.24.0
cboneti
added
the
release-version-updates
|
The relevant tests pass. The two failing tests are expected. |
harshthakkar01
approved these changes
Oct 19, 2023
cboneti
requested review from
nick-stroud
and removed request for
nick-stroud
nick-stroud
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Key New Features 🎉
Module Improvements 🔨
Improvements 🛠
Version Updates ⏫
Bug fixes 🐞
New Contributors
Full Changelog: v1.23.0...1.24.0