Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Packer example and adopt Toolkit practices #214

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Simplify Packer example and adopt Toolkit practices #214

merged 1 commit into from
Apr 18, 2022

Conversation

tpdownes
Copy link
Member

  • Packer template resource adopts standard Toolkit input settings for deployment_name and subnetwork_name
  • Packer template subnetwork_name will default to same value as used by the VPC resource

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes
Simplify Packer example
d392542 
* Packer template resource adopts standard Toolkit input settings for
  deployment_name and subnetwork_name
* Packer template subnetwork_name will default to same value as used by
  the VPC resource
@tpdownes tpdownes marked this pull request as ready for review April 18, 2022 15:03
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Apr 18, 2022
@tpdownes tpdownes merged commit 0e42b64 into GoogleCloudPlatform:develop Apr 18, 2022
@tpdownes tpdownes deleted the feat_packer_toolkit_inputs branch April 18, 2022 18:38
@tpdownes tpdownes mentioned this pull request Apr 18, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@tpdownes tpdownes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @nick-stroud