Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packer integration test #218

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Fix packer integration test #218

merged 1 commit into from
Apr 18, 2022

Conversation

tpdownes
Copy link
Member

#214 renamed the setting subnetwork to subnetwork_name and aligned its default value to that in the VPC resource. This PR eliminates the (now invalid) subnetwork variable in favor of allowing subnetwork_name to take on its default value.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • [] If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • [] Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes changed the base branch from main to develop April 18, 2022 22:03
@nick-stroud nick-stroud merged commit 9d74b1d into GoogleCloudPlatform:develop Apr 18, 2022
@tpdownes tpdownes deleted the fix_packer_integration_test branch April 18, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants