Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shared reservations #2640

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented May 25, 2024

  • Allow to specify reservation_name in "long format": projects/<project>/reservations/<reservation_name>
  • Add constraint If a reservation is specified, `var.zones` should be empty.

Depends on GoogleCloudPlatform/slurm-gcp#152 - Have to be landed together

Testing done:

...
  - id: static_nodeset
    source: community/modules/compute/schedmd-slurm-gcp-v6-nodeset
    use: [network]
    settings:
      node_count_static: 2
      node_count_dynamic_max: 0
      enable_placement: false  # placement is done on reservation
      reservation_name: X
      machine_type: n2-standard-2
...
  • Specific reservations without placement policy

    • Shared by full name - OK
    • Shared by short name - deploy error - OK
    • Local by full name - OK
    • Local by short name - OK
  • Specific reservations with placement policy

    • Local by full name - OK
    • Local by short name
    • Shared by full name - not supported - OK
    • Shared by short name - not supported - OK
    Screenshot 2024-06-05 at 4 42 42 PM
  • Automatic reservations

    • Local by short name - deploy error - OK
    • Local by full name - deploy error - OK
    • Shared by short name - deploy error - OK
    • Shared by full name - deploy error - OK

@mr0re1 mr0re1 self-assigned this May 25, 2024
@mr0re1 mr0re1 marked this pull request as draft May 31, 2024 06:57
@mr0re1 mr0re1 requested a review from tpdownes June 5, 2024 22:32
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Jun 5, 2024
@mr0re1 mr0re1 marked this pull request as ready for review June 5, 2024 22:33
@mr0re1 mr0re1 assigned nick-stroud and unassigned tpdownes Jun 5, 2024
@mr0re1 mr0re1 requested a review from nick-stroud June 5, 2024 23:52
@mr0re1 mr0re1 added release-improvements Added to release notes under the "Improvements" heading. release-module-improvements Added to release notes under the "Module Improvements" heading. and removed release-improvements Added to release notes under the "Improvements" heading. labels Jun 5, 2024
@mr0re1 mr0re1 added the do-not-merge Block merging of this PR label Jun 6, 2024
@mr0re1 mr0re1 removed the do-not-merge Block merging of this PR label Jun 6, 2024
@mr0re1 mr0re1 merged commit 8655c01 into GoogleCloudPlatform:develop Jun 6, 2024
25 of 50 checks passed
@mr0re1 mr0re1 deleted the v6_shared_reserve branch June 6, 2024 20:54
@alyssa-sm alyssa-sm mentioned this pull request Jun 20, 2024
@mr0re1 mr0re1 mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants