Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'source' argument for path to prolog or epilog scripts #2670

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add 'source' argument for path to prolog or epilog scripts #2670

merged 1 commit into from
Jun 20, 2024

Conversation

andybubu
Copy link
Contributor

@andybubu andybubu commented Jun 7, 2024

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@andybubu andybubu force-pushed the prolog_epilog branch 2 times, most recently from a94328e to 990fa08 Compare June 7, 2024 17:34
@andybubu andybubu marked this pull request as ready for review June 7, 2024 18:20
@mr0re1
Copy link
Collaborator

mr0re1 commented Jun 8, 2024

Review postponed until GoogleCloudPlatform/slurm-gcp#158 is decicded

@mr0re1 mr0re1 self-assigned this Jun 8, 2024
@mr0re1
Copy link
Collaborator

mr0re1 commented Jun 13, 2024

GoogleCloudPlatform/slurm-gcp#158 have landed , though it didn't make it to latest tagged release.
I will get back to this PR early next week.

@mr0re1
Copy link
Collaborator

mr0re1 commented Jun 20, 2024

/gcbrun

@mr0re1 mr0re1 added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jun 20, 2024
@mr0re1 mr0re1 merged commit 3f14c04 into GoogleCloudPlatform:develop Jun 20, 2024
12 of 53 checks passed
@mr0re1 mr0re1 mentioned this pull request Jun 26, 2024
Merged
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@mr0re1 mr0re1

Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybubu @mr0re1