Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started with "Hello World" Cloud Functions Sample - Docs Updates #570

Closed
sadohert opened this issue Feb 24, 2018 · 1 comment
Closed

Comments

@sadohert
Copy link

Trying to work through the "Hello World" Cloud Functions tutorial. For context, this is my first crack at installing node on my Ubuntu box, and almost no nodejs programming experience (so maybe this is me :) ).

Here's the abbreviated sequence of events and possible changes to docs:

  • Clone and navigate to nodejs-docs-samples/functions/helloworld. Run "npm test"
  • Get error output like this

...

test/updateFunctions.sh: 4: test/updateFunctions.sh: functions: not found

...
  • I realise I need the Cloud Functions emulator installed.
    SUGGESTION 1 Add a note about this in the Prerequisites section of nodejs-docs-samples/functions/README.md
    SUGGESTION 2 Add a test for existence of the function somewhere. Is this possible?

  • Install the emulator to provide the "function" function (ugh :) ) following these instructions

  • Run "$npm test" again and it runs, but I get messages like this:

Node.js v6.11.5 or greater is required to run the Emulator!

SUGGESTION - Be more specific about the node version needed. If its not a global problem (i.e., only isolated to Cloud Functions samples) add the checks to the code? I ended up installing a very recent node (v9.6.1) and had further issues because it was too new (apparently I need a 6.x version...sorry, maybe this should have been obvious, but I don't know node well yet).

I guess I could make these changes myself and do a PR?

@fhinkel
Copy link
Contributor

fhinkel commented Nov 10, 2018

Closing this due to inactivity. Please re-open if needed.

@fhinkel fhinkel closed this as completed Nov 10, 2018
ace-n pushed a commit that referenced this issue Nov 10, 2022
NimJay pushed a commit that referenced this issue Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NimJay pushed a commit that referenced this issue Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this issue Nov 11, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 11, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 14, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 15, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 15, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this issue Nov 17, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 17, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
ace-n pushed a commit that referenced this issue Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [3.20.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.19.0...v3.20.0) (2021-10-19)


### Features

* Update osconfig v1 and v1alpha RecurringSchedule.Frequency with DAILY frequency ([#569](https://www.github.com/googleapis/nodejs-asset/issues/569)) ([af03fd5](https://www.github.com/googleapis/nodejs-asset/commit/af03fd5c4fba4a258acf4c0332991bcb619fa10b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this issue Nov 17, 2022
Fixes http://b/208672646. Test looks good, going to add comment to Java and Python test files to be similar to Node.js test.
Shabirmean pushed a commit that referenced this issue Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants