migrate code from googleapis/nodejs-asset

[ahrarmonsur]

• initialize repo
• add a samples/package.json
• chore: do a little lint cleanup (Add Logging API example. #53)
• docs(samples): add quickstart code for ExportAssets (Added instructions for running the tests. Fixes #49. #50)
• refactor(samples): convert sample tests from ava to mocha (Added Pub/Sub samples. #56)
• fix: fix the lint rules (Move back to container-based Travis builds and removed some redundant tests. #58)
• sample: Add quickstart sample code for BatchGetAsstesHistory. (Add logging example and link to instructions for Compute Engine as well #59)
• Release v0.1.1 (Google Cloud Functions - Node.js Version #67)
• fix: fix sample tests (Cannot deploy my app to App Engine after Installing Parse Dashboard #79)
• Release v0.2.0 (Add region tags to GKE Dockerfile. #95)
• fix(deps): update dependency yargs to v13 (Add basic Endpoints sample. #105)
• chore(deps): update dependency mocha to v6
• Release v0.2.1 (How to add the environment variables in Windows? #117)
• Release @google-cloud/asset v0.3.0 (getApplicationDefault is undefined.  #121)
• refactor: use execSync for tests (More Cloud Functions #127)
• feat: introduces 'expression text', deprecates version field (Switch back to mocha from ava. #143)
• docs: use repo-meta to generate README (Kraken app tests are flaky and break a lot #130)
• chore: release 1.0.0 (Switch Speech sample to v1beta1 #146)
• chore: release 1.1.0 (I have issue to add the json key file  #158)
• chore: release 1.1.1 (Add list_datasets_and_projects sample #161)
• chore: release 1.1.2 (Pubsub tests #164)
• fix(deps): update dependency @google-cloud/storage to v3 (Start storagetransfer samples. #168)
• chore: release 1.1.3 (Switch to individual API packages. #169)
• chore: release 1.1.4 (Translate API samples #176)
• fix(deps): update dependency yargs to v14
• feat: introduce v1p2beta1 client (Auto-generate command instructions for README.md #181)
• chore: release 1.2.0 (All Storage samples are now up to standard. #182)
• docs: add real time feed api sample code (Add Translate API samples. Fixes #176. #184)
• chore: release 1.2.1 (Export data from BigQuery samples #186)
• chore: release 1.3.0 (Update all dependencies 🌴 #191)
• chore: release 1.4.1 (Stackdriver product rename #209)
• fix(deps): update dependency @google-cloud/storage to v4 (Simplify BigQuery samples according to our standard. #207)
• chore: release 1.4.2 (Add quickstart tests #215)
• fix(deps): update dependency yargs to v15 (Fix pagination #222)
• chore: update license headers
• chore: release 1.5.0 (Simplify Storage samples and their tests. #225)
• feat(samples): update real time feed api sample code to use v1 API surface
• chore(deps): update dependency mocha to v7 (Upgrade apps for env:flex. #241)
• chore: release 1.6.0
• chore: release 1.6.1 (Update Cloud Functions error sample to use the Error Reporting module #252)
• feat!: converts library to TypeScript adding v1p1beta1 surface (@google-cloud/datastore 0.5.0 does not return entity keys with query results #250)
• chore: release 2.0.0 (Update Language samples. #254)
• chore: release 2.0.1 (Create My First Project-bb06314a336f.json #262)
• chore: release 2.1.0 (Secure websockets on app engine (?) #265)
• fix(deps): update dependency uuid to v7
• chore: release 2.2.0 (Add sample / docs for HSTS for requiring https #271)
• fix: in rare cases test can take longer than 180,000 timeout (Update Speech samples. #307)
• chore: linting (Removed deprecated flag from app.yaml #309)
• chore: release 3.0.0 (Not able to import in React.js | Not sure if browser support is available as no documentation about it #280)
• fix(deps): update dependency uuid to v8 (Fix issue with read-only transaction #325)
• fix(deps): update dependency @google-cloud/storage to v5 (Endpoints gRPC samples #330)
• chore: release 3.1.0 (Add key parameter to translate quickstart #324)
• chore(deps): update dependency mocha to v8 (update the sentiment threshold; fix a typo in some commented-out code. #341)
• docs(samples): add sample code for SearchAllResources and SearchAllIamPolicies (sampleRate is not a field: undefined #343)
• chore: release 3.2.0 (Replace node-mailer module with something else #338)
• chore: release 3.3.0 (Update openApi config to use "security" instead of "x-security". #347)
• chore: release 3.4.0 (speech streaming example doesn't work #350)
• feat(samples): add sample code for ListAssets v1p5beta1 (package.json needs update to pull the right version of google-gax@0.13.2  #355)
• chore: release 3.5.0 (Update NL client library version #356)
• chore: release 3.5.1 (updated readme for the renaming of files #372)
• chore: release 3.6.0 (Add new video samples #382)
• chore: release 3.7.0 (Update the sample template. #387)
• fix(deps): update dependency yargs to v16 (update sample to use @google-cloud/error-reporting #391)
• chore: release 3.7.1 (Add postgres samples #396)
• chore: release 3.8.0 (insertRowsAsStream not showing full error log #399)
• chore: release 3.9.0 (Move DLP from REST to gRPC + client libraries #413)
• chore: release 3.9.1 (speechClient.recognize() giving empty array as response? #425)
• chore: release 3.10.0 (Adds example with word time offsets. #437)
• chore: release 3.11.0 (Unit Test instructions in README fail (missing semistandard dependency call-out) #446)
• feat(samples): add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning (Add openapi-appengine.yaml file for App Engine deployments. #433)
• docs: fix yaml parsing error in comments ([DO NOT MERGE] Update/add tests + fix dependencies #452)
• chore: release 3.12.0 (Update index.js #450)
• chore: release 3.12.1 (Fix for the bug: pod error ImagePullBackOff #482)
• chore: release 3.12.2 (Update Monitoring samples. #493)
• chore: release 3.13.0 (Nitfix: move mock-only code out of region tag #494)
• chore: release 3.14.0 (Temporarily revert "Remove video samples which have moved." #506)
• samples: Update asset lib to v1 for ListAssets sample code (Remove video samples which have moved. #505)
• chore: release 3.14.1 (How can I create audio file that node.js google speech server can recognize?? #508)
• chore: release 3.15.0 (Cloud Tasks samples. #516)
• chore: release 3.15.1 (bigquery-stream-data-nodejs docs - use correct json property to check for errors #519)
• chore: release 3.15.2 (MQTT client JWT refresh and set TLS to 1.2 #521)
• chore: release 3.15.3 (error ECONNREFUSED #523)
• chore: release 3.15.4 (Move bigquery and vision samples. #535)
• chore: release 3.15.5 (functions/datastore sample #536)
• chore: release 3.16.0 (Iot mqtt tests #539)
• chore: release 3.16.1 (Update comment and add region tags #540)
• chore: release 3.17.0 (Update mqtt dependency #543)
• chore: release 3.18.0 (Update README.md #549)
• chore: release 3.19.0 (Move datastore samples. #552)
• samples: add relationship support samples (Re-doing region tag changes to correct test error #560)
• docs(samples): add auto-generated samples for Node with api short name in region tag (app.yaml s/python/nodejs in comment #562)
• test: extend timeout for flaky tests (Bug fix for helloGCSGeneric() #567)
• chore: release 3.20.0 (Getting started with "Hello World" Cloud Functions Sample - Docs Updates #570)
• chore: release 3.21.0 (Change to endpoints managed rollout #576)
• chore: release 3.22.0 (Added samples for App Engine Standard Environment #579)
• samples: Move sample code end tag to the correct line for GetFeed (chore: update (most) dependencies + (some) samples #583)
• chore(main): release 3.23.0 (Google Cloud IOT getClient example timeout with no other errors #603)
• chore(main): release 3.23.1 (Fix typo in gcloud command #605)
• build!: update library to use Node 12 (puppeteer sample (Headless Chrome) #625)
• test: increase sample test timeout (Tweak HTTP sample comments #628)
• fix(deps): update dependency @google-cloud/bigquery to v6 (Move description from docs into code sample #630)
• fix(deps): update dependency @google-cloud/storage to v6 (Extract/re-work samples from "Execution environment" page #629)
• samples: fix compute test, update dependency to V3 (Add description to code comments for HTTP #634)
• chore(main): release 4.0.0 (Audio Stream Timing Out Instantly #626)
• chore(main): release 4.1.0 (Add missing lint dependency #636)
• chore(main): release 4.2.0 (Fix permission of bash script #645)
• feat: add batchGetEffectiveIamPolicies sample code. (No need for the --disable-setuid-sandbox flag #654)
• fix(deps): update dependency uuid to v9 (Upgrade repo-tools to fix some failing system tests. #657)
• chore(main): release 4.3.0 (Migrate tests to Kokoro #652)
• chore(main): release 4.4.0 (Do not deploy to AppEngine in Presubmit #659)
• chore(main): release 4.5.0 (Slow "Browser" instance creation w/ Headless Chrome GAE Standard Node.js #671)

[snippet-bot]

Here is the summary of changes.

You are about to add 15 region tags.

• asset/snippets/analyzeIamPolicy.js:23, tag asset_quickstart_analyze_iam_policy
• asset/snippets/analyzeIamPolicyLongrunningBigquery.js:23, tag asset_quickstart_analyze_iam_policy_longrunning_bigquery
• asset/snippets/analyzeIamPolicyLongrunningGcs.js:23, tag asset_quickstart_analyze_iam_policy_longrunning_gcs
• asset/snippets/createFeed.js:23, tag asset_quickstart_create_feed
• asset/snippets/deleteFeed.js:23, tag asset_quickstart_delete_feed
• asset/snippets/exportAssets.js:23, tag asset_quickstart_export_assets
• asset/snippets/exportAssetsBigquery.js:23, tag asset_quickstart_export_assets_bigquery
• asset/snippets/getBatchAssetHistory.js:23, tag asset_quickstart_batch_get_assets_history
• asset/snippets/getBatchEffectiveIamPolicies.js:23, tag asset_quickstart_batch_get_effective_iam_policies
• asset/snippets/getFeed.js:23, tag asset_quickstart_get_feed
• asset/snippets/listAssets.js:24, tag asset_quickstart_list_assets
• asset/snippets/listFeeds.js:23, tag asset_quickstart_list_feeds
• asset/snippets/searchAllIamPolicies.js:23, tag asset_quickstart_search_all_iam_policies
• asset/snippets/searchAllResources.js:23, tag asset_quickstart_search_all_resources
• asset/snippets/updateFeed.js:23, tag asset_quickstart_update_feed

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ace-n]

Can you add a workflow config to .github/workflows for this, so that the tests run?

Be sure to add the config to .github/workflows/workflows.json, too. ✅

[ahrarmonsur]

The CI was failing due to lack of tests being carried over (the one mega-test in samples.test.js was marked as a quickstart test). However, it appears that one file was calling the tests for all the samples.

On @grayside's advice to unblock this PR, I have:

• Created a tracking issue for language maintainers to refactor the tests to be sample-specific: Tests for asset/snippets/test/ need to be refactored #2864
• Removed the workflow for asset samples

Context is in this conversation

[ace-n]

Should these files be in asset/snippets/, or the asset directory itself?

[ace-n]

Did you mean to include this file?

[ahrarmonsur]

This singular test file includes not just the quickstart tests, but tests for all the other samples, as well. They are run sequentially.

I included it in the migration, so that when the language maintainers address the GH issue I created (#2864), they would have the body of the individual tests already and could use their best judgment to modify them as needed to decompose into separate test files. At that point, I imagine the samples.test.js will be deleted.

I figure inclusion of this file here is acceptable tech debt for the migration. Since @sofisl already discarded most of the tests for her migration to google-cloud-node, I didn't want to lose it in the migration/archival process.

[ahrarmonsur]

To address your other comment about migration destination:
i (and I believe most others) are following the example set in the migration guide, written by @grayside. You can see here that the samples end up <product>/snippets:
https://docs.google.com/document/d/1YhpsM5ylBFDunRsd-Vq7pHRNUz3uh9TUbOkJOZwCmOk/edit?resourcekey=0--XOS_x8NmzOS8_Qws-Qsug#bookmark=kix.z1viwa6f4215

[ace-n]

Omitting the snippets directory feels cleaner to me, but IMO it's not worth creating a new PR.

LGTM. ✅