Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message, explicitly delete legacy formatted functions #649

Merged
merged 7 commits into from
Jun 12, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 7, 2018

Drive-by fix: delete semistandard from global depenencies
Use correct bucket and region variable.

Do not merge - PR to see Kokoro failures.

@fhinkel fhinkel added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2018
Drive-by fix: delete semistandard from global depenencies
Use correct bucket and region variable.
@fhinkel fhinkel force-pushed the wipFixFunctionsKokoro branch from 09eb5c8 to d0208ef Compare June 7, 2018 08:28
@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e41de2...ce0cd77. Read the comment docs.

@fhinkel fhinkel removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 11, 2018
@fhinkel fhinkel merged commit 21dc72c into master Jun 12, 2018
@fhinkel fhinkel deleted the wipFixFunctionsKokoro branch June 12, 2018 00:09
kweinmeister pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants