Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code from googleapis/nodejs-error-reporting #2821

Merged
merged 72 commits into from
Nov 11, 2022

Conversation

kweinmeister
Copy link
Collaborator

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 10, 2022
@google-cla
Copy link

google-cla bot commented Nov 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NimJay
Copy link
Contributor

NimJay commented Nov 10, 2022

cla/google GitHub CI check overridden. ✅

@kweinmeister kweinmeister marked this pull request as ready for review November 10, 2022 21:38
@kweinmeister kweinmeister requested review from a team as code owners November 10, 2022 21:38
@snippet-bot
Copy link

snippet-bot bot commented Nov 10, 2022

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does quickstart.js belong in the google-cloud-node repository? Update: it's fine to keep it here, per internal conversation.

jmdobry and others added 22 commits November 10, 2022 16:22
* Add semistandard as a devDependency

* Fix storage tests

* Fix language tests

* Update (some) dependencies

* Fix language slackbot tests
* Fix docs-samples tests, round 1

* Fix circle.yml

* Add RUN_ALL_BUILDS flag

* More container builder bugfixes

* Tweak env vars + remove manual proxy install

* Env vars in bashrc don't evaluate dynamically, so avoid them

* Add semicolons for command ordering

* Add appengine/static-files test to circle.yaml

* Fix failing container builder tests

* Address comments
BREAKING CHANGE: This change renames the `Errors` class to `ErrorReporting`.
* Fixing vulnerability reported by snyk

That does not cause any harm to this samples package but I want to keep snyk dashboard clean.

* require the correct version of the main package

* undo version change
* chore: lock files maintenance

* chore: lock files maintenance
* chore: lock files maintenance

* chore: lock files maintenance
* chore: lock files maintenance

* chore: lock files maintenance

* chore: lock files maintenance
JustinBeckwith and others added 26 commits November 10, 2022 16:22
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [gaxios](https://github.com/googleapis/gaxios) | devDependencies | major | [`^2.0.1` -> `^3.0.0`](https://renovatebot.com/diffs/npm/gaxios/2.3.4/3.0.2) |

---

### Release Notes

<details>
<summary>googleapis/gaxios</summary>

### [`v3.0.2`](https://github.com/googleapis/gaxios/blob/master/CHANGELOG.md#&#8203;302-httpswwwgithubcomgoogleapisgaxioscomparev301v302-2020-03-24)

[Compare Source](https://github.com/googleapis/gaxios/compare/v3.0.1...v3.0.2)

### [`v3.0.1`](https://github.com/googleapis/gaxios/blob/master/CHANGELOG.md#&#8203;301-httpswwwgithubcomgoogleapisgaxioscomparev300v301-2020-03-23)

[Compare Source](https://github.com/googleapis/gaxios/compare/v3.0.0...v3.0.1)

### [`v3.0.0`](https://github.com/googleapis/gaxios/blob/master/CHANGELOG.md#&#8203;300-httpswwwgithubcomgoogleapisgaxioscomparev232v300-2020-03-19)

[Compare Source](https://github.com/googleapis/gaxios/compare/1dbfe6b672f84285baf430d9dea8d280f8147c7a...v3.0.0)

##### ⚠ BREAKING CHANGES

-   **deps:** TypeScript introduced breaking changes in generated code in 3.7.x
-   drop Node 8 from engines field ([#&#8203;254](https://github.com/googleapis/gaxios/issues/254))

##### Features

-   drop Node 8 from engines field ([#&#8203;254](https://www.github.com/googleapis/gaxios/issues/254)) ([8c9fff7](https://www.github.com/googleapis/gaxios/commit/8c9fff7f92f70f029292c906c62d194c1d58827d))
-   **deps:** updates to latest TypeScript ([#&#8203;253](https://www.github.com/googleapis/gaxios/issues/253)) ([054267b](https://www.github.com/googleapis/gaxios/commit/054267bf12e1801c134e3b5cae92dcc5ea041fab))

##### [2.3.2](https://www.github.com/googleapis/gaxios/compare/v2.3.1...v2.3.2) (2020-02-28)

##### Bug Fixes

-   update github repo in package ([#&#8203;239](https://www.github.com/googleapis/gaxios/issues/239)) ([7e750cb](https://www.github.com/googleapis/gaxios/commit/7e750cbaaa59812817d725c74fb9d364c4b71096))

##### [2.3.1](https://www.github.com/googleapis/gaxios/compare/v2.3.0...v2.3.1) (2020-02-13)

##### Bug Fixes

-   **deps:** update dependency https-proxy-agent to v5 ([#&#8203;233](https://www.github.com/googleapis/gaxios/issues/233)) ([56de0a8](https://www.github.com/googleapis/gaxios/commit/56de0a824a2f9622e3e4d4bdd41adccd812a30b4))

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-error-reporting).
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) |

---

### Release Notes

<details>
<summary>mochajs/mocha</summary>

### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#&#8203;801--2020-06-10)

[Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1)

The obligatory patch after a major.

#### 🐛 Fixes

-   [#&#8203;4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@&#8203;boneskull**](https://github.com/boneskull))

### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#&#8203;800--2020-06-10)

[Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0)

In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below.

Let's welcome [**@&#8203;giltayar**](https://github.com/giltayar) and [**@&#8203;nicojs**](https://github.com/nicojs) to the maintenance team!

#### 💥 Breaking Changes

-   [#&#8203;4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@&#8203;UlisesGascon**](https://github.com/UlisesGascon))

-   [#&#8203;4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@&#8203;juergba**](https://github.com/juergba))

    ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs).

-   [#&#8203;4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@&#8203;craigtaub**](https://github.com/craigtaub))

    ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`.

-   [#&#8203;4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@&#8203;juergba**](https://github.com/juergba))

    ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`).

-   [#&#8203;4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@&#8203;juergba**](https://github.com/juergba))

-   [#&#8203;4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@&#8203;arvidOtt**](https://github.com/arvidOtt))

-   [#&#8203;4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@&#8203;juergba**](https://github.com/juergba))

-   [#&#8203;4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@&#8203;wnghdcjfe**](https://github.com/wnghdcjfe)):
    -   `Mocha.prototype.ignoreLeaks()`
    -   `Mocha.prototype.useColors()`
    -   `Mocha.prototype.useInlineDiffs()`
    -   `Mocha.prototype.hideDiff()`

#### 🎉 Enhancements

-   [#&#8203;4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@&#8203;boneskull**](https://github.com/boneskull))

    ❗ See also [#&#8203;4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_

-   [#&#8203;4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@&#8203;JacobLey**](https://github.com/JacobLey))

-   [#&#8203;4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@&#8203;giltayar**](https://github.com/giltayar))

#### 📖 Documentation

-   [#&#8203;4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@&#8203;boneskull**](https://github.com/boneskull))

#### 🐛 Fixes

(All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above)

</details>

---

### Renovate configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-error-reporting).
Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* build!: Update library to use Node 12
Co-authored-by: Summer Ji <summerji@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@ace-n ace-n force-pushed the nodejs-error-reporting-migration branch from 4ed30db to 77ba53f Compare November 11, 2022 00:22
@ace-n ace-n merged commit 6511cf0 into main Nov 11, 2022
@ace-n ace-n deleted the nodejs-error-reporting-migration branch November 11, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.