Samples/gulp #81
Closed
Samples/gulp #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| // Lint Task | ||
| gulp.task('lint', function() { | ||
| return gulp.src(['Gulpfile.js', 'src/**/*.js']) |
There was a problem hiding this comment.
Can you reformat this file with 2-space indentation instead of 4? Thanks.
|
Just a couple fixes needed. After they're fixed, can you squash into 1 commit? Then I'll merge. |
|
Sounds good, thanks |
|
Feel free to re-open if you're able to fix the conflicts or give me edit access (you should see an "Allow Maintainers to Edit" checkbox on this PR. |
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 8, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 9, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…nter-insights (#2817) - feat: initial generation of templated files - feat: add initial samples (#2) - chore(deps): update dependency mocha to v9 (#3) - chore: release 1.0.0 (#1) - chore: release 1.0.1 (#12) - chore: release 1.0.2 (#18) - chore: release 1.1.0 (#21) - chore: release 1.2.0 (#26) - chore: release 1.2.1 (#29) - chore: release 1.3.0 (#36) - chore: release 1.4.0 (#40) - samples: get operation (#52) - samples: create conversation, create analysis, export data to BigQuery (#34) - samples: enable pubsub notifications (#48) - samples: modify TTL in create conversation with TTL sample (#57) - samples: create topic model (#49) - chore: release 1.5.0 (#58) - samples: set project-level TTL (#51) - samples: create custom highlights (#53) - chore: release 1.6.0 (#65) - chore: release 1.7.0 (#69) - chore: release 1.8.0 (#75) - chore: release 1.9.0 (#81) - chore(main): release 1.11.0 (#107) - build: add retries for flaky test (#109) - build!: update library to use Node 12 (#122) - chore(main): release 2.0.0 (#124) - fix(deps): update dependency @google-cloud/bigquery to v6 (#127) - fix(deps): update dependency @google-cloud/pubsub to v3 (#126) - chore(main): release 2.0.1 (#129) - chore(main): release 2.1.0 (#134) - chore(main): release 2.1.1 (#139) - chore(deps): update dependency uuid to v9 (#142)
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.5](https://www.github.com/googleapis/nodejs-workflows/compare/v1.2.4...v1.2.5) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#80](https://www.github.com/googleapis/nodejs-workflows/issues/80)) ([0b782cf](https://www.github.com/googleapis/nodejs-workflows/commit/0b782cff0eddcd158fcbd272c76e54e35b6d336c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.5](https://www.github.com/googleapis/nodejs-workflows/compare/v1.2.4...v1.2.5) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#80](https://www.github.com/googleapis/nodejs-workflows/issues/80)) ([0b782cf](https://www.github.com/googleapis/nodejs-workflows/commit/0b782cff0eddcd158fcbd272c76e54e35b6d336c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
rogerthatdev
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.5](https://www.github.com/googleapis/nodejs-workflows/compare/v1.2.4...v1.2.5) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#80](https://www.github.com/googleapis/nodejs-workflows/issues/80)) ([0b782cf](https://www.github.com/googleapis/nodejs-workflows/commit/0b782cff0eddcd158fcbd272c76e54e35b6d336c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 16, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic gulp + express sample