Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename untyped featuregate to comply with feature gate character set restrictions #769

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Rename untyped featuregate to comply with feature gate character set restrictions #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/collector/googlemanagedprometheus/extra_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const (
// prometheus metric. Internal use only.
GCPOpsAgentUntypedMetricKey = "prometheus.googleapis.com/internal/untyped_metric"

gcpUntypedDoubleExportGateKey = "gcp.untyped_double_export"
gcpUntypedDoubleExportGateKey = "gcp.untypedDoubleExport"
)

var untypedDoubleExportFeatureGate = featuregate.GlobalRegistry().MustRegister(
Expand Down
2 changes: 1 addition & 1 deletion exporter/collector/googlemanagedprometheus/naming_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func TestGetMetricName(t *testing.T) {
expected: "bar/gauge",
},
{
desc: "untyped sum with gcp.untyped_double_export disabled only normalizes",
desc: "untyped sum with gcp.untypedDoubleExport disabled only normalizes",
baseName: "bar",
metric: func(m pmetric.Metric) {
//nolint:errcheck
Expand Down
2 changes: 1 addition & 1 deletion exporter/collector/integrationtest/testcases/testcases_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ var MetricsTestCases = []TestCase{
ConfigureCollector: func(cfg *collector.Config) {
configureGMPCollector(cfg)
//nolint:errcheck
featuregate.GlobalRegistry().Set("gcp.untyped_double_export", true)
featuregate.GlobalRegistry().Set("gcp.untypedDoubleExport", true)
},
// prometheus_target is not supported by the SDK
SkipForSDK: true,
Expand Down