Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename untyped featuregate to comply with feature gate character set restrictions #769

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole requested a review from a team as a code owner November 13, 2023 17:08
@dashpole
Copy link
Contributor Author

cc @ridwanmsharif

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #769 (6cc27d9) into main (0b578e8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   69.52%   69.52%           
=======================================
  Files          42       42           
  Lines        4859     4859           
=======================================
  Hits         3378     3378           
  Misses       1331     1331           
  Partials      150      150           
Files Coverage Δ
...collector/googlemanagedprometheus/extra_metrics.go 79.79% <ø> (ø)
...tor/integrationtest/testcases/testcases_metrics.go 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dashpole dashpole merged commit 337c81d into GoogleCloudPlatform:main Nov 13, 2023
25 checks passed
@dashpole dashpole deleted the featuregate_naming branch November 13, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants