-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloud.google.com/go and OTel dependencies #867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dashpole looks like a vulncheck failure and I can't quite figure out the issue with the other tests, the user-agent string has changed so maybe it needs a fixture update? But I see that you updated the fixtures already
I've isolated the user-agent problem to googleapis/google-cloud-go#10402 |
Blocked by googleapis/google-cloud-go#10550 |
The workaround proposed in googleapis/google-cloud-go#10550 (comment) works. |
Test coverage failure tracked here: #865 This should be good to go otherwise |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v1.24.0` -> `v1.24.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0/v1.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fdetectors%2fgcp/v1.24.0/v1.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v0.48.1-0.20240618202726-8ffe2564d48b` -> `v0.48.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fextension%2fgoogleclientauthextension/v0.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fextension%2fgoogleclientauthextension/v0.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fextension%2fgoogleclientauthextension/v0.48.1-0.20240618202726-8ffe2564d48b/v0.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fGoogleCloudPlatform%2fopentelemetry-operations-go%2fextension%2fgoogleclientauthextension/v0.48.1-0.20240618202726-8ffe2564d48b/v0.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-go (github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension)</summary> ### [`v0.48.1`](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.1): v1.24.1 and v0.48.1 [Compare Source](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/compare/v0.48.0...v0.48.1) #### What's Changed - \[chore] update deprecated use of CreateSettings by [@​codeboten](https://togithub.com/codeboten) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/862](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/862) - fix(googleclientauth/idtoken): use metadata server when credential json is not available by [@​rinx](https://togithub.com/rinx) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/863](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/863) - Update cloud.google.com/go and OTel dependencies by [@​dashpole](https://togithub.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/867](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/867) - Update to otel-go codecov presubmit by [@​dashpole](https://togithub.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/868](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/868) - Fix typo in intToDoubleFeatureGate by [@​chingis-fiskil](https://togithub.com/chingis-fiskil) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870) - Prerelease 1.24.1/v0.48.1 by [@​damemi](https://togithub.com/damemi) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/872](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/872) #### New Contributors - [@​chingis-fiskil](https://togithub.com/chingis-fiskil) made their first contribution in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870) **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-go@v0.48.0...v0.48.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
I need to update these to address #864. I'm doing it in a separate PR to minimize the diff.