Update to otel-go codecov presubmit #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 61.03% 61.70% +0.66%
==========================================
Files 56 58 +2
Lines 5903 6050 +147
==========================================
+ Hits 3603 3733 +130
- Misses 2143 2157 +14
- Partials 157 160 +3 ☔ View full report in Codecov by Sentry. |
|
Lint will be fixed after rebasing on #867 |
damemi
approved these changes
Jul 16, 2024
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jul 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v1.24.0` -> `v1.24.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go) | `v0.48.1-0.20240618202726-8ffe2564d48b` -> `v0.48.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-go (github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension)</summary> ### [`v0.48.1`](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.1): v1.24.1 and v0.48.1 [Compare Source](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/compare/v0.48.0...v0.48.1) #### What's Changed - \[chore] update deprecated use of CreateSettings by [@​codeboten](https://togithub.com/codeboten) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/862](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/862) - fix(googleclientauth/idtoken): use metadata server when credential json is not available by [@​rinx](https://togithub.com/rinx) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/863](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/863) - Update cloud.google.com/go and OTel dependencies by [@​dashpole](https://togithub.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/867](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/867) - Update to otel-go codecov presubmit by [@​dashpole](https://togithub.com/dashpole) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/868](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/868) - Fix typo in intToDoubleFeatureGate by [@​chingis-fiskil](https://togithub.com/chingis-fiskil) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870) - Prerelease 1.24.1/v0.48.1 by [@​damemi](https://togithub.com/damemi) in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/872](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/872) #### New Contributors - [@​chingis-fiskil](https://togithub.com/chingis-fiskil) made their first contribution in [https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/870) **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-go@v0.48.0...v0.48.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #865
As a first pass, i'm applying some of the improvements that otel-go has implemented (open-telemetry/opentelemetry-go#5440, open-telemetry/opentelemetry-go#5534) to see if those fix our issues.
Codecov passed (both creating the coverage, and uploading it)!