Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to disable autosync for buildpacks #4805

Merged

Conversation

briandealwis
Copy link
Member

Description

With #4656 landing in Skaffold 1.14.0, we automatically enable autosync for buildpacks artifacts. This PR documents what file types are supported, and how to disable auto-sync.

@briandealwis
Copy link
Member Author

FYI @russwolf

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #4805 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4805      +/-   ##
==========================================
- Coverage   71.82%   71.61%   -0.22%     
==========================================
  Files         347      348       +1     
  Lines       11869    12026     +157     
==========================================
+ Hits         8525     8612      +87     
- Misses       2725     2778      +53     
- Partials      619      636      +17     
Impacted Files Coverage Δ
pkg/skaffold/build/tag/util.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/skaffold/deploy/helm.go 74.61% <0.00%> (-2.54%) ⬇️
pkg/skaffold/debug/debug.go 38.59% <0.00%> (-2.15%) ⬇️
pkg/skaffold/runner/new.go 64.05% <0.00%> (-1.92%) ⬇️
pkg/skaffold/deploy/kustomize.go 76.19% <0.00%> (-0.24%) ⬇️
pkg/skaffold/kubectl/cli.go 100.00% <0.00%> (ø)
pkg/skaffold/deploy/kubectl/cli.go 87.34% <0.00%> (ø)
cmd/skaffold/app/cmd/filter.go 26.19% <0.00%> (ø)
pkg/skaffold/deploy/kubectl.go 66.00% <0.00%> (+0.26%) ⬆️
cmd/skaffold/app/cmd/cmd.go 65.89% <0.00%> (+0.26%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4eb4a...c66f37d. Read the comment docs.

@briandealwis briandealwis merged commit 65583f1 into GoogleContainerTools:master Sep 23, 2020
@briandealwis briandealwis deleted the disable-autosync branch September 23, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants