Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto sync mode for Buildpacks artifacts #4656

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4651

Description

Change Buildpacks artifacts to default to automatic sync. This is a safe change as:

  • The auto sync mechanism requires that the image contains buildpacks metadata defining the file types to be synced; if this metadata is not found (e.g., using something other than GCP Buildpacks) then no sync rules are defined and a full rebuild is triggered for each file change.
  • The GCP Buildpacks are conservative in their listed file types.

The default can be avoided by defining a manual or infer rule:

   artifacts:
   - image: nodejs-hello-world
     buildpacks:
       builder: gcr.io/buildpacks/builder:v1
     sync:
      manual:
       # following rule never matches anything but prevents auto syncing
      - src: '...'
        dest: '...'

User facing changes (remove if N/A)

Buildpacks artifacts now default to enabling auto sync

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #4656 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4656   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         339      339           
  Lines       13320    13322    +2     
=======================================
+ Hits         9751     9753    +2     
  Misses       2958     2958           
  Partials      611      611           
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 91.00% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5c603...c2e37f1. Read the comment docs.

Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold should default to auto-sync for supported builders
3 participants