Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Warning message "The additionalFlags field in kaniko is deprecated" #4853

Closed
wants to merge 1 commit into from
Closed

Remove Warning message "The additionalFlags field in kaniko is deprecated" #4853

wants to merge 1 commit into from

Conversation

ricardo-larosa
Copy link
Contributor

Fixes: #4852

Description

To avoid confusion remove the warning message The additionalFlags field in kaniko is deprecated

User facing changes

Given a skaffold.yaml

profiles:
- name: oncluster
  build:
    artifacts:
    - image: myregistry/myimage:mytag
      kaniko:
        image: gcr.io/kaniko-project/executor:v1.0.0
        flags: 
          - --snapshotMode=redo
          - --verbosity=info
  • Before:
level=warning msg="The additionalFlags field in kaniko is deprecated, please consult the current schema at skaffold.dev to update your skaffold.yaml."
  • After:

No warning messages

But if --verbosity=TRACE

TRAC[0004] kaniko additionalFlags are --snapshotMode=redo --verbosity=info 

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #4853 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4853   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files         356      356           
  Lines       12216    12216           
=======================================
  Hits         8778     8778           
  Misses       2786     2786           
  Partials      652      652           
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/pod.go 87.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c10069...4904dbc. Read the comment docs.

@briandealwis
Copy link
Member

We've been trying to create new config items, such as for docker secrets (#4731). Since we publish JSON schema settings, IDEs and editors can validate and offer auto-complete support, which is really helpful. Would you be willing to try turning this into a PR to add Kaniko support?

@ricardo-larosa
Copy link
Contributor Author

Hi @briandealwis Yes :)

@briandealwis
Copy link
Member

Closing in anticipation of a different impementation.

@ricardo-larosa
Copy link
Contributor Author

Hi @briandealwis kaniko implementation #4900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warning message "The additionalFlags field in kaniko is deprecated"
3 participants