-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended Kaniko support #4900
Extended Kaniko support #4900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
==========================================
+ Coverage 71.96% 72.07% +0.10%
==========================================
Files 357 358 +1
Lines 12327 12364 +37
==========================================
+ Hits 8871 8911 +40
+ Misses 2799 2797 -2
+ Partials 657 656 -1
Continue to review full report at Codecov.
|
@@ -32,7 +33,7 @@ const ( | |||
defaultCloudBuildDockerImage = "gcr.io/cloud-builders/docker" | |||
defaultCloudBuildMavenImage = "gcr.io/cloud-builders/mvn" | |||
defaultCloudBuildGradleImage = "gcr.io/cloud-builders/gradle" | |||
defaultCloudBuildKanikoImage = constants.DefaultKanikoImage | |||
defaultCloudBuildKanikoImage = kaniko.DefaultImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this into kaniko package!
Btw great stuff! I've been running hacks to have kaniko configured the way we wanted, now it's supported and I couldn't be happier :D |
Fixes: #4852
Related: #4853
Description
Implement kaniko flags as skaffold config items.
User facing changes (remove if N/A)
Support for
additionalFlags
akaflags:
is removed
Example:
Before
Now
Limitations/Scope
Does not implement kaniko
--git
tag nor related.Notes
It looks long but is due to the number of flags implemented.