Make it possible to disable auto-sync

[briandealwis]

Fixes: #4806

Description
Turn the sync.auto to a boolean.

User facing changes (remove if N/A)

• auto-sync can now be disabled with sync.auto = false on the respective artifacts

[codecov]

Codecov Report

Merging #4923 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master    #4923   +/-   ##
=======================================
  Coverage   72.18%   72.19%           
=======================================
  Files         358      358           
  Lines       12402    12409    +7     
=======================================
+ Hits         8953     8959    +6     
- Misses       2795     2796    +1     
  Partials      654      654           

Impacted Files	Coverage Δ
pkg/skaffold/schema/latest/config.go	100.00% <ø> (ø)
pkg/skaffold/schema/v2beta8/upgrade.go	88.88% <66.66%> (-11.12%)	⬇️
pkg/skaffold/build/buildpacks/env.go	87.50% <100.00%> (ø)
pkg/skaffold/schema/defaults/defaults.go	89.09% <100.00%> (ø)
pkg/skaffold/build/result.go	86.66% <0.00%> (+1.30%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8b798...a1b02dd. Read the comment docs.

[loosebazooka]

There's some docs and code in examples that use auto:{}
for jib specifically: (/integration)/examples/jib-syc

[briandealwis]

@loosebazooka 5f29e27 fixed the auto:{} in integration/examples/jib-sync, so they'll come through on the next release.

[loosebazooka]

oh weird, I must have clicked on the commit or something

[loosebazooka]

Looks fine to me, what happens when we need to configure auto in the future? should buildpacks not automatically enable sync?

[briandealwis]

Auto sync is now enabled by default for buildpacks (#4656). Disabling requiring specifying a manual sync rule. Oops, I didn't update the docs!

[loosebazooka]

How does that interact with the "one of" parsing of yaml? I'm not sure I remember what happens if the user injects some manual sync into the buildpacks artifact configuration?

[briandealwis]

The oneOf is only checked at parse time: it has no effect on the underlying Go structs.

The auto-sync enablement happens as port-processing step, and only happens when there are no manual or inferred rules.

[container-tools-bot]

Please visit http://35.235.68.162:1313 to view changes to the docs.